Add ImageTask priority property to replace setPriority method

README.md

@@ -174,7 +174,7 @@ Tasks can be used to monitor download progress, cancel the requests, and dynamic
 
 ```swift
 task.cancel()
-task.setPriority(.high)
+task.priority = .high
 ```
 
 > To learn more about the `ImagePipeline` [see the dedicated section](#h_design).

Sources/ImagePipeline.swift

@@ -129,7 +129,7 @@ public /* final */ class ImagePipeline {
 
     func imageTaskUpdatePriorityCalled(_ task: ImageTask, priority: ImageRequest.Priority) {
         queue.async {
-            task.priority = priority
+            task._priority = priority
             guard let subscription = self.tasks[task] else { return }
             subscription.setPriority(priority)
         }
@@ -141,7 +141,7 @@ public /* final */ class ImagePipeline {
         guard task.isStartNeeded else { return }
         task.isStartNeeded = false
 
-        self.tasks[task] = getDecompressedImage(for: task.request).subscribe(priority: task.priority) { [weak self, weak task] event in
+        self.tasks[task] = getDecompressedImage(for: task.request).subscribe(priority: task._priority) { [weak self, weak task] event in
             guard let self = self, let task = task else { return }
 
             if event.isCompleted {
@@ -171,7 +171,7 @@ public /* final */ class ImagePipeline {
     private func startDataTask(_ task: ImageTask,
                                progress progressHandler: ((_ completed: Int64, _ total: Int64) -> Void)?,
                                completion: @escaping (Result<(data: Data, response: URLResponse?), ImagePipeline.Error>) -> Void) {
-        self.tasks[task] = getOriginalImageData(for: task.request) .subscribe(priority: task.priority) { [weak self, weak task] event in
+        self.tasks[task] = getOriginalImageData(for: task.request) .subscribe(priority: task._priority) { [weak self, weak task] event in
             guard let self = self, let task = task else { return }
 
             if event.isCompleted {

Sources/ImageTask.swift

@@ -43,7 +43,14 @@ public /* final */ class ImageTask: Hashable {
 
     /// The original request with which the task was created.
     public let request: ImageRequest
-    var priority: ImageRequest.Priority
+    var _priority: ImageRequest.Priority // Backing store for access from pipeline
+
+    /// Updates the priority of the task, even if the task is already running.
+    public var priority: ImageRequest.Priority {
+        didSet {
+            pipeline?.imageTaskUpdatePriorityCalled(self, priority: priority)
+        }
+    }
 
     /// The number of bytes that the task has received.
     public internal(set) var completedUnitCount: Int64 = 0
@@ -70,6 +77,7 @@ public /* final */ class ImageTask: Hashable {
     init(taskId: Int, request: ImageRequest) {
         self.taskId = taskId
         self.request = request
+        self._priority = request.priority
         self.priority = request.priority
     }
 
@@ -89,9 +97,9 @@ public /* final */ class ImageTask: Hashable {
         pipeline = nil // Zeroing weak references is always thread-safe
     }
 
-    /// Update s priority of the task even if the task is already running.
+    @available(*, deprecated, message: "Please use `var priority: ImageRequest.Priority`")
     public func setPriority(_ priority: ImageRequest.Priority) {
-        pipeline?.imageTaskUpdatePriorityCalled(self, priority: priority)
+        self.priority = priority
     }
 
     // MARK: - Internal

Tests/ImagePipelineDataCachingTests.swift

@@ -65,7 +65,7 @@ class ImagePipelineDataCachingTests: XCTestCase {
             return XCTFail("No operations gor registered")
         }
         expect(operation).toUpdatePriority()
-        task.setPriority(.high)
+        task.priority = .high
 
         wait()
     }

Tests/ImagePipelineDeduplicationTests.swift

@@ -384,7 +384,7 @@ class ImagePipelineDeduplicationTests: XCTestCase {
 
         // When/Then
         expect(operations.operations.first!).toUpdatePriority(from: .high, to: .low)
-        task.setPriority(.low)
+        task.priority = .low
         wait()
     }
 

Tests/ImagePipelineTests.swift

@@ -127,7 +127,7 @@ class ImagePipelineTests: XCTestCase {
             return XCTFail("Failed to find operation")
         }
         expect(operation).toUpdatePriority()
-        task.setPriority(.high)
+        task.priority = .high
 
         wait()
     }
@@ -150,7 +150,7 @@ class ImagePipelineTests: XCTestCase {
             return XCTFail("Failed to find operation")
         }
         expect(operation).toUpdatePriority()
-        task.setPriority(.high)
+        task.priority = .high
 
         wait()
     }
@@ -173,7 +173,7 @@ class ImagePipelineTests: XCTestCase {
             return XCTFail("Failed to find operation")
         }
         expect(operation).toUpdatePriority()
-        task.setPriority(.high)
+        task.priority = .high
 
         wait()
     }