fix: prevent hang when plugin calls client.app.log() during init#1
Closed
fix: prevent hang when plugin calls client.app.log() during init#1
Conversation
Skip Instance.provide middleware for /log endpoint to break circular dependency: plugin init → client.app.log() → /log route → Instance.provide → InstanceBootstrap → plugin init → infinite loop Ported from upstream PR #11642
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This fix is ported from upstream anomalyco/opencode PR #11642.
Bug Description
A circular dependency causes an infinite hang when a plugin calls
client.app.log()during initialization:client.app.log()during init/logroute is hitInstance.providemiddleware runsInstanceBootstraptries to initialize pluginsThe Fix
Skip the
Instance.providemiddleware for the/logendpoint. This breaks the circular dependency chain since logging operations no longer trigger instance/plugin initialization.The
/logendpoint doesn't require instance-specific context, so this is a safe optimization that prevents the hang without affecting functionality.