btrfs-progs: libbtrfsutil: use package_data member for header files #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide at least basic description of the library for pypi.org main page. It's for libbtrfsutil that mentions the C and python usage. [ ci skip ] Issue: kdave#310 Signed-off-by: David Sterba <[email protected]>
adam900710
force-pushed
the
python_headers_warning
branch
from
b46c1f5
to
d148df6
Compare
|
Added a new patch to fix the python packaging error. |
This mostly reverts the commit 8f1f2e7 ("libbtrfsutil: update btrfsutil long description"). There is no need to introduce such a drama to create a temporary pypi-README.md, just reuse the existing one in libbtrfsutil/README.md. This does not only make the code simpler, but pass CI. Issue: kdave#310 Fixes: 8f1f2e7 ("libbtrfsutil: update btrfsutil long description") Signed-off-by: Qu Wenruo <[email protected]>
[BUG]
Currently with python3.12, the python bindding will always result the
following warning:
[PY] libbtrfsutil
/usr/lib/python3.12/site-packages/setuptools/_distutils/extension.py:134: UserWarning: Unknown Extension options: 'headers'
warnings.warn(msg)
[CAUSE]
In the setup.py which specifies the files to be included into the
package, we use setuptools::Extension to specify the file lists and
include paths.
But there is no handling of Extension::headers member, thus resulting
the above warning.
[FIX]
Not an expert in python, but other packages like cffi are all using
`package_data` to include the headers, so just follow them to use
`package_data` member for headers.
Fixes: 87c3fb5 ("libbtrfsutil: update python setup.py for distribution")
Signed-off-by: Qu Wenruo <[email protected]>
adam900710
force-pushed
the
python_headers_warning
branch
from
d148df6
to
ef82e57
Compare
|
The existing setup.py is a disaster, as it doesn't work for venv builds. Furthermore it doesn't follow the common python packaging directory hierarchy, it will be much better to do a rework on the build system so that at least venv build can work properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG]
Currently with python3.12, the python bindding will always result the following warning:
[CAUSE]
In the setup.py which specifies the files to be included into the package, we use setuptools::Extension to specify the file lists and include paths.
But there is no handling of Extension::headers member, thus resulting the above warning.
[FIX]
Not an expert in python, but other packages like cffi are all using
package_datato include the headers, so just follow them to usepackage_datamember for headers.Fixes: 87c3fb5 ("libbtrfsutil: update python setup.py for distribution")