btrfs-progs: open the devices exclusively for writes #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an internal report that, during btrfs-convert to block-group tree, by accident some systemd events triggered the mount of the target fs. This leads to double mount (one by kernel and one by the btrfs-progs), which seems to cause quite some problems. To avoid such accident, exclusively opens all devices if btrfs-progs is doing write operations. Reported-by: pandada8 <[email protected]> Signed-off-by: Qu Wenruo <[email protected]>
kdave
approved these changes
Sep 12, 2024
kdave
pushed a commit
that referenced
this pull request
Sep 12, 2024
There is an internal report that, during btrfs-convert to block-group tree, by accident some systemd events triggered the mount of the target fs. This leads to double mount (one by kernel and one by the btrfs-progs), which seems to cause quite some problems. To avoid such accident, exclusively opens all devices if btrfs-progs is doing write operations. Pull-request: #888 Reported-by: pandada8 <[email protected]> Signed-off-by: Qu Wenruo <[email protected]>
kdave
pushed a commit
that referenced
this pull request
Sep 12, 2024
There is an internal report that, during btrfs-convert to block-group tree, by accident some systemd events triggered the mount of the target fs. This leads to double mount (one by kernel and one by the btrfs-progs), which seems to cause quite some problems. To avoid such accident, exclusively opens all devices if btrfs-progs is doing write operations. Pull-request: #888 Reported-by: pandada8 <[email protected]> Signed-off-by: Qu Wenruo <[email protected]>
kdave
pushed a commit
that referenced
this pull request
Sep 12, 2024
There is an internal report that, during btrfs-convert to block-group tree, by accident some systemd events triggered the mount of the target fs. This leads to double mount (one by kernel and one by the btrfs-progs), which seems to cause quite some problems. To avoid such accident, exclusively opens all devices if btrfs-progs is doing write operations. Pull-request: #888 Reported-by: pandada8 <[email protected]> Signed-off-by: Qu Wenruo <[email protected]>
kdave
pushed a commit
that referenced
this pull request
Sep 17, 2024
There is an internal report that, during btrfs-convert to block-group tree, by accident some systemd events triggered the mount of the target fs. This leads to double mount (one by kernel and one by the btrfs-progs), which seems to cause quite some problems. To avoid such accident, exclusively opens all devices if btrfs-progs is doing write operations. Pull-request: #888 Reported-by: pandada8 <[email protected]> Signed-off-by: Qu Wenruo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an internal report that, during btrfs-convert to block-group tree, by accident some systemd events triggered the mount of the target fs.
This leads to double mount (one by kernel and one by the btrfs-progs), which seems to cause quite some problems.
To avoid such accident, exclusively opens all devices if btrfs-progs is doing write operations.
Reported-by: pandada8 [email protected]