Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Fixed typos across the repository #3151

Merged
merged 1 commit into from
Aug 15, 2024
Merged

🌱 Fixed typos across the repository #3151

merged 1 commit into from
Aug 15, 2024

Conversation

gauravgahlot
Copy link
Contributor

Summary

Fixes typos across the repository.

Related issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2024
@kcp-ci-bot
Copy link
Contributor

Hi @gauravgahlot. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2024
@embik
Copy link
Member

embik commented Aug 14, 2024

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2024
embik
embik requested changes Aug 15, 2024
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gauravgahlot, thanks a lot for the contribution! I have one minor request for dropping some changes, apart from that this PR looks great and we can merge it soon.

sdk/apis/third_party/conditions/apis/conditions/v1alpha1/constants.go Outdated
Comment on lines 134 to 137
const (
// MachineHealthCheckSuccededCondition is set on machines that have passed a healthcheck by the MachineHealthCheck controller.
// MachineHealthCheckSucceededCondition is set on machines that have passed a healthcheck by the MachineHealthCheck controller.
// In the event that the health check fails it will be set to False.
MachineHealthCheckSuccededCondition ConditionType = "HealthCheckSucceeded"
MachineHealthCheckSucceededCondition ConditionType = "HealthCheckSucceeded"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop those changes because they live in a third_party directory, which means the code has been imported from some upstream project. In this case, it's CAPI (#273). We shouldn't change third party code if we can avoid it. I'm not sure if this condition is actually used anywhere in our code, probably not, but changes on our end might make it more difficult to pull upstream code again.

@embik
Copy link
Member

embik commented Aug 15, 2024

One more request, can you please squash your commits into one? This repository doesn't squash on merge, so let's try to keep the git log tidy.

@gauravgahlot
fixed typos
21d5a28 
Signed-off-by: Gaurav Gahlot <[email protected]>
@gauravgahlot
Copy link
Contributor Author

/assign

@gauravgahlot
Copy link
Contributor Author

/retest

embik
embik approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

thank you for the contribution!

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fd0f3a9187ac43a4a18020e268abf9be6384179d

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2024
@kcp-ci-bot kcp-ci-bot merged commit 4caf1e6 into kcp-dev:main Aug 15, 2024
15 checks passed
@gauravgahlot gauravgahlot deleted the fixed-typos branch August 15, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

@gauravgahlot gauravgahlot

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gauravgahlot @kcp-ci-bot @embik