Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 5 Only #82

Closed
wants to merge 18 commits into from
Closed

Svelte 5 Only #82

wants to merge 18 commits into from

Conversation

anatoliy-t7
Copy link

The package will work with Svelte 5 Only

  • migrate to Svelte 5 syntaxis
  • update all packages
  • small fix

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-french-toast ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 3:07am

@mustafa0x
Copy link

@anatoliy-t7 nice work! but i think the last commit should be deleted.

@anatoliy-t7 anatoliy-t7 mentioned this pull request Oct 9, 2024
@anatoliy-t7
Copy link
Author

@anatoliy-t7 nice work! but i think the last commit should be deleted.

I don't want to get credits from work that @kbrgl did. I just rewrote it a little.

Copy link

@okuruu okuruu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@writeDavid
Copy link

@kbrgl what do you think of these changes? Now that Svelte 5 is officially out, it makes sense to ensure projects can upgrade and still use this project.

@mustafa0x
Copy link

should use pnpm-lock instead of adding package-lock

@enesbala5
Copy link

Can we please get an update on this? I need to use the library for a project - it seems like everything is ready at this point, right?

@thebjorn
Copy link
Contributor

@enesbala5 and everyone else... I don't speak for @kbrgl (at all), and I understand that people want releases to move faster. Things you can do to help make it happen:

  • submit a CI pipeline PR to run the tests in github Actions (will make it easier to verify that new changes doesn't break anything)
  • submit a PR that adds more tests (test coverage also make releases faster/easier)
  • submit a CD pipeline PR that automatically publishes tagged versions to github and npm.
  • help answer/triage issues
  • help review PRs

If you don't have time to help out, you can always

  • use the current version (I know it at least worked with Svelte 5 in June).
  • fork the repo
  • vendorize the repo + this PR
  • hire someone to do any of the above ;-)

@babakfp
Copy link

babakfp commented Nov 2, 2024

I published this https://github.com/babakfp/svelte-hot-french-toast if anyone interested. Uses Svelte 5 and runes.

Copy link

@DollarAkshay DollarAkshay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bn-l
Copy link

bn-l commented Dec 27, 2024

Hey any updates?

@ezShroom
Copy link

well isn't this ready to go now?

@anatoliy-t7 anatoliy-t7 requested a review from kbrgl February 22, 2025 06:15
Copy link
Owner

@kbrgl kbrgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to merge this on my branch

@kbrgl
Copy link
Owner

kbrgl commented Feb 22, 2025

Closed in favor of #89.

@kbrgl kbrgl closed this Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.