Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Dockerfile to enable docker buildx #366

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

jsfillman
Copy link
Contributor

@jsfillman jsfillman commented May 27, 2022

Summary

This pull request simply updates the docker install line to:
apt-get -y install docker-ce docker-ce-cli containerd.io docker-compose-plugin

Justification

As part of DEVOPS-765, we're creating custom workflows for some repos (e.g. sample_service) to run make compile, which triggers the kb-sdk compile step.

The easiest way to make this work is to simply build using the kbase/kb-sdk image vs the stock ubuntu-latest image.
Since the custom workflows in question are based on our reusable workflows, they need the ability to build using the docker buildx command.

Testing

  • A test version of kb-sdk was build using the proposed Dockerfile, and pushed to jsfillman/kb-sdk.
  • The reusable workflows were modified to utilize this image and run make compile in the kbase/sdk-compile-test repo, which is a copy of kbase/sample_service.
  • All relevant workflows were tested:
    • ✅ Pull Request Build, Tag, & Push
    • ✅ Build Production Release Image
    • ✅ Manual Build & Push

@jsfillman jsfillman requested a review from ialarmedalien May 27, 2022 00:41
@jsfillman
Copy link
Contributor Author

For clarity, the intent is to:

  1. Update kb-sdk to enable docker buildx.
  2. Add the proposed modified workflows only to repos that need to run kb-sdk compile (via make compile.
  3. Leave the main reusable workflows in kbase/.github as-is for now.

@ialarmedalien ialarmedalien force-pushed the DEVOPS-765-add_buildx branch from e4b6186 to 13093f4 Compare March 15, 2023 18:57
@ialarmedalien ialarmedalien force-pushed the DEVOPS-765-add_buildx branch from 13093f4 to 0ab2a97 Compare March 15, 2023 20:33
@ialarmedalien ialarmedalien merged commit 3a7e1b2 into develop Mar 15, 2023
@ialarmedalien ialarmedalien deleted the DEVOPS-765-add_buildx branch March 15, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants