Repository navigation
fix(vite-dev-server): sync remaining Vite fixes - #52
Merged
Merged
Conversation
…ators Port vitejs/vite#23038 (17f7b2f19). getFileStartIndex() is used by the dev import analysis. The config bundling part only updates the commented-out upstream code, and the css.ts and importAnalysisBuild.ts parts are not ported.
…fter server close Port vitejs/vite#23572 (6f831f9ad). makeWatcherCloseFinal() is ported to watch.ts, but it is not applied to the watchers from watcherFactory: the virtual watcher is frozen and its add() never opens file system handles.
Port vitejs/vite#23513 (bbc8812be). The module runner sourcemap interceptor and ssrStacktrace parts are not ported, so decodeSourceURL() is not used yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync the remaining upstream Vite fixes that the previous syncs left out:
getFileStartIndex()is used by the dev import analysis. The config bundling part only updates the commented-out upstream code, and thecss.tsandimportAnalysisBuild.tsparts are not ported.makeWatcherCloseFinal()towatch.ts. It is not applied to watchers fromwatcherFactory, because the virtual watcher is frozen and itsadd()never opens file system handles.NOTE(kazupon)comments at both call sites explain why.sourceURL. The sourcemap interceptor andssrStacktraceparts are not ported, sodecodeSourceURL()is not used yet.The upstream tests rely on config loading, chokidar and SSR, so unit tests cover
getFileStartIndex()with each line terminator,makeWatcherCloseFinal()and thesourceURLhelpers instead.Validated with typecheck, lint,
vp run test:unit:vite:node(663 → 674 tests) and the@vrowzer/vite-dev-serverbuild. Integration and E2E tests were not run locally.