Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cornerRadius value on UnderlineFocusView #120

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Add cornerRadius value on UnderlineFocusView #120

merged 2 commits into from
Apr 22, 2020

Conversation

devmjun
Copy link
Contributor

@devmjun devmjun commented Apr 16, 2020

I add values that are cornerRadius and masksToBounds. because of developing UI such as the attached image.

Please review myPR. thank you :)

@kazuhiro4949
Copy link
Owner

kazuhiro4949 commented Apr 18, 2020 •
edited
Loading

@devmjun Thanks! Could you remove IDEWorkspaceChecks.plist? It's a configuration for your local environment.

@devmjun
Copy link
Contributor Author

devmjun commented Apr 20, 2020

@kazuhiro4949 I removed it🙇‍♂️

@kazuhiro4949 kazuhiro4949 merged commit 21fc974 into kazuhiro4949:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazuhiro4949 kazuhiro4949 kazuhiro4949 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devmjun @kazuhiro4949