Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ci = FALSE to svyquantile function #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chipmanj
Copy link
Contributor

Hi Kazuki,

I too came across issue #83. As noted by, @docvock, the source of the problem is that survey updated the default output of the svyquantile function. Here's further elaboration:

The previous default input for svyquantile was ci=FALSE. Now it is ci=TRUE.

survey(version 4.0): https://www.rdocumentation.org/packages/survey/versions/4.0/topics/svyquantile
survey(version 4.1): https://rdrr.io/cran/survey/man/svyquantile.html

Under survey (v4.1), svyQuant (within tableone) returns a quantile, 95% ci, and standard error (a numeric vector of size 4) for each variable. Previously, svyQuant only returned a quantile (singleton) for each variable.

As a downstream effect, the error regarding rounding occurs when updating the class of the result object (created within svyCreateContTable). I was not able to track down why this particular error occurred. However, the proposed pull request resolves the original problem by setting ci = FALSE when calling svyquantile (within tableone::svyQuant).

I tested the updates using the NHANES example within ?svyCreateTableOne.

I hope you are well and best wishes,

Jonathan Chipman

@kaz-yos
Copy link
Owner

kaz-yos commented Feb 3, 2022

Thanks for tracking this down! I'm investigating the R-CMD-check issue with ubuntu devel.

@chipmanj
Copy link
Contributor Author

chipmanj commented Feb 4, 2022

You're welcome!!!

@kaz-yos
Copy link
Owner

kaz-yos commented Feb 24, 2022

TODO: Figure out the following error:

Run options(crayon.enabled = TRUE)
[2](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:2)
  options(crayon.enabled = TRUE)
[3](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:3)
  rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"), error_on = "warning", check_dir = "check")
[4](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:4)
  shell: /usr/local/bin/Rscript {0}
[5](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:5)
  env:
[6](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:6)
    R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
[7](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:7)
    RSPM: https://packagemanager.rstudio.com/cran/__linux__/focal/latest
[8](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:8)
    GITHUB_PAT: ***
[9](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:9)
    R_LIBS_USER: /home/runner/work/_temp/Library
[10](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:10)
    TZ: UTC
[11](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:11)
    _R_CHECK_SYSTEM_CLOCK_: FALSE
[12](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:12)
    NOT_CRAN: true
[13](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:13)
    _R_CHECK_CRAN_INCOMING_REMOTE_: false
[14](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:14)
Error: Error in loadNamespace(x) : there is no package called ‘rcmdcheck’
[15](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:15)
Calls: loadNamespace -> withRestarts -> withOneRestart -> doWithOneRestart
[16](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:16)
Execution halted
[17](https://github.com/kaz-yos/tableone/runs/5058870960?check_suite_focus=true#step:9:17)
Error: Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants