syncing from original #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Outsider <[email protected]>
* update an example for browsers in docs * fix docs build command * remove jquery in a browser example Signed-off-by: Outsider <[email protected]>
* run cycle overview * adjust flow format * add to table of contents * code highlighting points of interest * remove highlighting * java code highlighting * fix lint error * language change. swap parse+exec for run * use back-ticks for it + describe. uppercase title. * invoked to executed * add comment, make ui-generic, swap arrows * Swap java back to js as highlighting the same
* use latest ruby-ffi * update all deps
* Clarify docs for watch that it watches files in the CWD * s/CWD/current working directory
Signed-off-by: Outsider <[email protected]>
### Description of the Change Replaced all method headers with more complete documentation, better following recommended styles. Eliminated `@api` tags, as `@access` _should_ imply same. Used `@chainable` to denote class methods returning `this` instance. Renamed a handful of variables, but **no logic changes**! ### Alternate Designs N/A ### Why should this be in core? N/A ### Benefits API documentation will be more useful if more complete. ### Possible Drawbacks N/A ### Applicable issues semver-patch
* docs: improve CONTRIBUTING.md and fix/remove links * docs: link to CONTRIBUTING.md in readme * docs: address PR comments [skip ci] * docs: better wording on PR review wait time [skip ci]
As noted by @plroebuck `level` is not used, should be `label` instead. 37193a4#commitcomment-30530038
- Any non-extensible type thrown in an async callback raises an exception in Mocha runner, stopping tests.
* ci(.travis.yml): Squelch Growl-related spawn errors Installed binary needed for Linux desktop notification support. * ci(appveyor.yml): Squelch Growl-related spawn errors Installed GfW package needed for Windows desktop notification support. Fixes #3483
… to timeout The `Base` reporter's specification verifies reporter can interpret Chai custom error messages. This test takes ~480ms (lightly loaded CPU), which is _way_ too close to the 500ms timeout. Change doubles this timeout. #3524
Additionally, this includes minor updates to mocha's help output (by rewording text and/or specifying default values). These were then collected into the website documentation.
### Description of the Change * Made all output directly use `process.stdout`. * `process.stdout` and `console.log` take different routes to get to same place * Corrected ctor name. * Updated documentation. ### Alternate Designs N/A ### Benefits Consistency. [Don't cross the streams](https://www.youtube.com/watch?v=wyKQe_i9yyo)! ### Possible Drawbacks N/A ### Applicable issues Fixes #3526 Fixes #3521 semver-patch
Previously undocumented that use of `--inspect` would disable timeouts. Fixes #3519
Prettier-ESLint keeps busying itself with the JSDoc output directory upon any commit, spewing hundreds of errors. This tells both ESLint and Git to ignore the directory.
* ci(.travis.yml,appveyor.yml): Update Node versions in CI matrix Make Node-11 the new default and drop Node-9 from matrix.
Signed-off-by: Outsider <[email protected]>
* Give a `DeprecationWarning` on suite callback returning any value. * Deprecation warning: Show a message only once; use `process.nextTick` when falling back to `console.warn` * Add a test for `utils.deprecate` * style: Make prettier happy * test(deprecate.spec.js): Make PR requested changes for approval (per @boneskull)
* upgrade jekyll; closes #3548 see https://nvd.nist.gov/vuln/detail/CVE-2018-17567 * add .ruby-version for netlify
While refactoring the `dot` reporter test, we created a method for capturing output from running the reporter. It proved so handy at squelching test "noise" that JeongHoon extracted it and applied it to many of the other reporters.
- this will fix a problem with npm (potentially) publishing certain files which should always be ignored; see npm/npm-packlist#14. - also fixes issue with growl images not getting published! - add `directories` property for metadata PRO TIP: use `npm pack --dry-run` to see what would be included in published tarball.
* fix(lib/runnable.js): Prevent timeout value from skirting limit check
- Moved the timestring->value translation code to before the limit check.
- Found that previous "fix" hadn't actually fixed the correct value, as the wrong upper bound value had been used (off by one error).
- Further research indicated that some versions of IE had problems with negative timeout values. New code clamps to nonnegative numbers ending at `INT_MAX`.
- Updated the function documentation.
* feat(lib/utils.js): Add `clamp` function
- New function clamps a numeric value to a given range.
* test(unit/runnable.spec.js): Updated tests for `#timeout(ms)`
- Restructured `Runnable#timeout` tests to check both numeric/timestamp input values that:
- less than lower limit
- equal to lower limit
- within limits
- equal to upper limit
- greater than upper limit
Closes #1652
* Refactored code to use `TAPProducer` objects to write output. * Added TAP specification 13 output producer. * Version line * Errors and stacktraces inside YAML blocks * Added TAP specification 12 output producer [default]. * Added `reporterOptions.tapVersion` to target TAP producer. * Refactored to make use of `runner.stats` * Refactored to use `process.stdout` stream exclusively. * Updated to test against both specifications and incorporate work from PR #3528. * Added integration tests for specification conformance.
* Added new public `version` property to `Mocha`, available in both Node and browser. * Used `browserify` transform to prevent exposing any other package details (for security).
'Nuff said...
* add console.log ref * inherit println * unit test change * use static property and fix test * fix base test * rename consoleLog * test include Base.consoleLog check * linter rule so reporters dont console.log * use hooks for stubs with base test * restore stub dont callThrough * fix test + rebase * fix faulty rebase. Removed printLn * remove superfluous base
This commit prepares improvements to the watch mode behavior. In the future we want Mocha in watch mode to pick up new test files. This requires that the test files are collected inside `watchRun` instead of before. To accomplish this change we rename `handleFiles` to `collectFiles` and move it to its own module. Instead of calling `collectFiles` in `lib/cli/run` and passing the files on to `watchRun` or `singleRun` we pass down the file collection parameters through `runMocha` and call `collectFiles` in both `watchRun` and `singleRun`.
We remove code that called `mocha.grep(null)` on watch re-runs if the `--grep` option was not supplied. The code seems to serve no purpose and is the cause of #2027.
* hide stacktrace when cli args is missing Signed-off-by: Outsider <[email protected]> * Update lib/cli/options.js Co-Authored-By: David da Silva <[email protected]> * remove unused lines Signed-off-by: Outsider <[email protected]>
…fix broken link in jsdoc tutorial (#3966)
…3955) Use "isTTY" instead of tty.isatty(fd)
Signed-off-by: Outsider <[email protected]>
* Added Matomo to index.md * Fixed * Deleted <p> * Deleted center tag and added style css * Requested changes done * Changed Matomo logo to another file * Changing css and adding aside to html * Fixed height and width * Fixed identations * Deleted footer logo * Requested changes done * Last changes * Trim and eresize matomo image * Remove resizing, it increased image weight * Retain matomo image aspect ratio
The fact that code inside of a skipped suite is executed, is potentially counter-intuitive. By using alternative phrasing, we make it clear how mocha handles code in skipped suites. Closes #3932
support of Node v0.9.11 has been dropped years ago.
Update yargs-parser to v13.1.1
* Add link checking to docs build step * Update hyperlink to 4.3.0 * Update @mocha/docdash to 2.1.2 * Fix internal broken fragment links from jsdoc comments to front page * Mark source code line fragment link checks as TODO. They are runtime JS generated and can't be found by hyperlink * Document reporters.Base.prototype.epilogue as a member of the right thing, thus not breaking docs links * Update to hyperlink 4.3.1 * Update to jsdoc 3.6.3 * experiment: add acorn 7 as dev dependency to attempt to fix broken build * Fix broken links from tutorial. Use jsdoc link functionality instead of guessign url's * Make hyperlink skipfilter argument windows compatible
* OJSF coc * update email
Improved watching with chokidar. This change improves the file watching behavior and fixes #3912. * We introduce the `--watch-files` command line option. This option allows control over which files are and is separate and more powerful than `--extension`. Fixes #2702. * We introduce the `--watch-ignore` command line option that allows control over which files are not watched. Before this was hardcoded to `node_modules` and `.git`. See #2554. * The `chokidar` package now handles file watching. * New test files are picked up by the file watcher and run. Fixes #2176. * Watch hidden files based on extension
* add OpenJS Foundation logo to website * fix flaky template Signed-off-by: Christopher Hiller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.