Merge pull request #678 from aereal/ssm-get-parameters

fix: use GetParameters instead of GetParameter to simulate actual ECS' behavior
kayac · Mar 19, 2024 · 7143a5f · 7143a5f
2 parents ec85dec + 416147e
commit 7143a5f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/docs/iam-policy-example.json b/docs/iam-policy-example.json
@@ -18,7 +18,7 @@
 				"logs:GetLogEvents",
 				"secretsmanager:GetSecretValue",
 				"servicediscovery:GetNamespace",
-				"ssm:GetParameter",
+				"ssm:GetParameters",
 				"sts:AssumeRole"
 			],
 			"Resource": "*"

diff --git a/tests/terraform/iam.tf b/tests/terraform/iam.tf
@@ -73,7 +73,6 @@ resource "aws_iam_policy" "ecs-task-execution" {
           "logs:CreateLogGroup",
           "logs:CreateLogStream",
           "logs:PutLogEvents",
-          "ssm:GetParameter",
           "ssm:GetParameters",
           "secretsmanager:GetSecretValue",
         ]

diff --git a/verify.go b/verify.go
@@ -116,8 +116,8 @@ func (v *verifier) existsSecretValue(ctx context.Context, from string) error {
 	} else {
 		name = from
 	}
-	_, err := v.ssm.GetParameter(ctx, &ssm.GetParameterInput{
-		Name:           &name,
+	_, err := v.ssm.GetParameters(ctx, &ssm.GetParametersInput{
+		Names:          []string{name},
 		WithDecryption: aws.Bool(true),
 	})
 	if err != nil {