Add state methods to delegate #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kawoou
reviewed
Feb 13, 2018
| @@ -305,6 +314,8 @@ open class DrawerController: UIViewController, UIGestureRecognizerDelegate { | |||
| /// Golden-Path | |||
| guard isEnable() else { return } | |||
| guard !isAnimating else { return } | |||
|
|
|||
| delegate?.drawerWillCloseSide?(drawerController: self) | |||
There was a problem hiding this comment.
Could you pass this state using the self.drawerSide value?
|
Please support Rx delegating. |
|
Ah, forgot about Rx. Just pushed it |
kawoou
reviewed
Feb 13, 2018
| @@ -358,7 +358,7 @@ open class DrawerController: UIViewController, UIGestureRecognizerDelegate { | |||
| ss.didFinishAnimate(side: .none, percent: 0.0) | |||
|
|
|||
| ss.isAnimating = false | |||
| ss.delegate?.drawerDidCloseSide?(drawerController: ss) | |||
| ss.delegate?.drawerDidCloseSide?(drawerController: ss, side: ss.drawerSide) | |||
There was a problem hiding this comment.
If you do not write oldValue, there is likely to be some variation in the middle.
let oldDrawerSide = drawerSide
delegate?.drawerWillCloseSide?(drawerController: self, side: oldDrawerSide)
...
ss.delegate?.drawerDidCloseSide?(drawerController: ss, side: oldDrawerSide)
...|
|
||
| return ControlEvent(events: source) | ||
| } | ||
| public var didCloseSide: ControlEvent<DrawerSide> { |
|
Updated |
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.