Fix for lifecycle events / mac scripts & --no-arguments option#1
Fix for lifecycle events / mac scripts & --no-arguments option#1doctor-amaton merged 3 commits intokawatzaki:masterfrom
Conversation
…ecycle events. Add --no-arguments option to fix charlesguse#23
|
Wow this looks pretty good! I'm sorry I don't know why GitHub didn't consider this important enough to send me an email about it... I'll check it out and it'll be merged soon enough :) |
|
Done! I can't believe a switch fall-through going on! I'll be updating the npm package pretty soon. |
|
OK, I've updated the npm package to version 1.1.3. Also, in the future, https://github.com/kawatzaki/dr.amaton-run-script-os should be a better repo to do additional changing, as is the npm package repo (good package.json). I'll try keep an eye on PRs more often! |
|
Sorry if this is a stupid question, but I'm confused. My project currently depends on Is this? or is it this? |
|
@ibc Hello there :P Well this repository is "ready" to be merged whenever @charlesguse wakes up from his Odin Sleep... The one I suggested on my previous comment (https://github.com/kawatzaki/dr.amaton-run-script-os) is identical, it only has a different package.json, which makes reference to the npm I hope that clears your doubts! |
|
Sure, clear. Thanks! |
It looked like this was the preferred fork for lifecycle events - I ran into some issues with scripts on the mac and with the second argument in the original command ("version" in "npm version patch") overriding the lifecycle event ("postversion").
Small refactor to give npm_lifecycle_event priority over npm_config_argv to support lifecycle events.
Fixed an issue with no scripts found on mac (darwin or nix)
Also, added --no-arguments option to fix charlesguse#23