Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TCFv2 vendor list request #3

Merged
merged 1 commit into from
Oct 9, 2021
Merged

fix TCFv2 vendor list request #3

merged 1 commit into from
Oct 9, 2021

Conversation

katie-ta
Copy link
Owner

@katie-ta katie-ta commented Oct 7, 2021

Summary

Fix request to fetch the TCF Vendor List to work with TCFv2.

Other small updates:

  • make everything camelCase for style purposes
  • rename "vendorlist" to "vendorList"

Test

kind of hacked a test, since the rest of the extension isn't working;

  • called loadVendors() directly
  • printed out output of request and verified it contained vendor list information:

Screen Shot 2021-10-07 at 12 26 36 AM

Reviewers

@charles-tan

// vendorlist is not in localstorage, load it from IAB's website
document.getElementById('vendors').appendChild(document.createTextNode('Loading vendorlist...'));
fetch_vendorlist();
function fetchVendorList() {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved this function to be be defined after showVendors since it calls showVendors

@charles-tan charles-tan merged commit a7b762c into main Oct 9, 2021
@charles-tan charles-tan deleted the kta--fix-vendor-list branch October 9, 2021 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants