[#15] set up boilerplate for modules & hot reloading #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katie-ta
changed the title
katie-ta
changed the title
katie-ta
force-pushed
the
kta--boilerplate-module
branch
from
74be615
to
53b8c94
Compare
added 3 commits
October 25, 2021 10:55
charles-tan
reviewed
Oct 25, 2021
src/js/background.js
Outdated
| case GET_TC_DATA_CALL: | ||
| // TODO: write function to handle getTCData response | ||
| console.log('received tcData!', message.data); | ||
| window.clearInterval(fetchDataIntervalId); |
There was a problem hiding this comment.
Should we clear this interval? Maybe if cookie preferences change we'll want to keep fetching data.
There was a problem hiding this comment.
yeah good point. removed!
charles-tan
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #15
Summary
The old version of the extension didn't have ES6 module capabilities, which was difficult since it relied on external libraries. Specifically, it would have been ideal to be able to import the iabtcfcore package to decode the consent string, so it looks like it hard-coded it instead.
This change adds some chrome extension boilerplate from https://github.com/samuelsimoes/chrome-extension-webpack-boilerplate. Doing so adds:
popup.js) and the background page (background.js)background.jswill do what the oldpopup.jsdoes.I also noticed that the api's for message passing between the content script (
uCookie.js) and the background script (formerlypopup.js) were not following best practices for message passing, according to the chrome docs. I believe we want to have a long-lived connection between the two, so I updated the implementation accordingly.Test
background.js&uCookie.jsable to pass messages to one another@charles-tan