Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Update GitHub labels #1670

Merged
merged 2 commits into from
Jun 5, 2019

Conversation

jodh-intel
Copy link
Contributor

Add the missing labels wip and do-not-merge which got dropped from the new set of GitHub labels.

Also removed the old from: entries which no longer apply since we've now moved to the new set of labels.

Fixes: #1669.

Signed-off-by: James O. D. Hunt [email protected]

Remove the `from:` entries which no longer apply since we've now moved
to the new set of labels.

Signed-off-by: James O. D. Hunt <[email protected]>
Add the missing labels `wip` and `do-not-merge` which got dropped from
the new set of GitHub labels.

Fixes: kata-containers#1669.

Signed-off-by: James O. D. Hunt <[email protected]>
Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks @jodh-intel

@grahamwhaley
Copy link
Contributor

I guess we should check those match what zuul is looking for...
in the zuul config files we can see:

- job:
    name: kata-github-wip
    description: |
      This job calls the github-wip playbook with a Kata-curated set of
      WIP labels and WIP title keywords
    run: playbooks/github-wip/run.yaml
    nodeset:
      nodes: []
    vars:
      wip_labels: 'do-not-merge wip rfc'
      wip_keywords: 'WIP RFC'

Yay, I think all three of do-not-merge, wip and rfc align :-)
I see you also have block @jodh-intel - does that need to be PR'd as an addition into the zuul WIP check config??

@grahamwhaley
Copy link
Contributor

ah, I see, block is a category, not a label - no need to try and add that to Zuul then.

@jodh-intel
Copy link
Contributor Author

Yep.

@chavafg
Copy link
Contributor

chavafg commented Jun 5, 2019

/test

@jodh-intel jodh-intel merged commit 91d85b0 into kata-containers:master Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back missing wip and do-not-merge labels
3 participants