This repository has been archived by the owner on May 12, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
network: Make tcfilter model as default #1502
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @egernst |
/test |
bergwolf
approved these changes
Apr 9, 2019
devimc
approved these changes
Apr 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amshinde please rebase it to fix travis
amshinde
force-pushed
the
make-tc-default
branch
from
April 9, 2019 17:22
272da98
to
bc9975c
Compare
/test |
mcastelino
approved these changes
Apr 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
Test failing due to a bug in the way netmon processes routes manifested only in tcfilter mode as routes are actually handled in this mode. |
amshinde
force-pushed
the
make-tc-default
branch
from
April 12, 2019 18:48
bc9975c
to
f3b9a6d
Compare
/test |
/retest |
egernst
approved these changes
Apr 15, 2019
tcfilter requires no changes to the interface provided by the network plugin and supports a larger set of plugins. Fixes kata-containers#1501 Signed-off-by: Archana Shinde <[email protected]>
Change the package level default network model to tcfilter. Signed-off-by: Archana Shinde <[email protected]>
amshinde
force-pushed
the
make-tc-default
branch
from
April 15, 2019 16:35
f3b9a6d
to
3852682
Compare
rebased changes.. |
ganeshmaharaj
pushed a commit
to ganeshmaharaj/kata-runtime
that referenced
this pull request
Apr 16, 2019
network: Make tcfilter model as default (cherry picked from commit edc77a0)
This was referenced Apr 16, 2019
ganeshmaharaj
pushed a commit
to ganeshmaharaj/kata-runtime
that referenced
this pull request
Apr 16, 2019
network: Make tcfilter model as default (cherry picked from commit edc77a0) Signed-off-by: Ganesh Maharaj Mahalingam <[email protected]>
ganeshmaharaj
pushed a commit
to ganeshmaharaj/kata-runtime
that referenced
this pull request
Apr 16, 2019
network: Make tcfilter model as default (cherry picked from commit edc77a0) Fixes: kata-containers#1501 Signed-off-by: Ganesh Maharaj Mahalingam <[email protected]>
ganeshmaharaj
pushed a commit
to ganeshmaharaj/kata-runtime
that referenced
this pull request
Apr 16, 2019
…c-default network: Make tcfilter model as default (cherry picked from commit edc77a0) Fixes: kata-containers#1501 Signed-off-by: Ganesh Maharaj Mahalingam <[email protected]>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tcfilter requires no changes to the interface provided by the network
plugin and supports a larger set of plugins.
Fixes #1501
Signed-off-by: Archana Shinde [email protected]