Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

network: Make tcfilter model as default #1502

Merged
merged 2 commits into from
Apr 15, 2019

Conversation

amshinde
Copy link
Member

@amshinde amshinde commented Apr 8, 2019

tcfilter requires no changes to the interface provided by the network
plugin and supports a larger set of plugins.

Fixes #1501

Signed-off-by: Archana Shinde [email protected]

@amshinde
Copy link
Member Author

amshinde commented Apr 8, 2019

cc @egernst
We probably need to evaluate our CI matrix, after this change. I think we had a CI job specifically for tcfilter, we would need to change that to macvtap in order tests runs for macvtap(or not?)

@grahamwhaley
Copy link
Contributor

/test

Copy link

@devimc devimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amshinde please rebase it to fix travis

@amshinde
Copy link
Member Author

amshinde commented Apr 9, 2019

/test

Copy link
Contributor

@mcastelino mcastelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bergwolf
Copy link
Member

/retest

@amshinde
Copy link
Member Author

Test failing due to a bug in the way netmon processes routes manifested only in tcfilter mode as routes are actually handled in this mode.
#1524 should fix this.

@caoruidong
Copy link
Member

/test

@egernst
Copy link
Member

egernst commented Apr 15, 2019

/retest

tcfilter requires no changes to the interface provided by the network
plugin and supports a larger set of plugins.

Fixes kata-containers#1501

Signed-off-by: Archana Shinde <[email protected]>
Change the package level default network model to tcfilter.

Signed-off-by: Archana Shinde <[email protected]>
@amshinde
Copy link
Member Author

rebased changes..
/test

@amshinde amshinde merged commit edc77a0 into kata-containers:master Apr 15, 2019
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-runtime that referenced this pull request Apr 16, 2019
network: Make tcfilter model as default
(cherry picked from commit edc77a0)
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-runtime that referenced this pull request Apr 16, 2019
network: Make tcfilter model as default
(cherry picked from commit edc77a0)
Signed-off-by: Ganesh Maharaj Mahalingam <[email protected]>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-runtime that referenced this pull request Apr 16, 2019
network: Make tcfilter model as default
(cherry picked from commit edc77a0)

Fixes: kata-containers#1501

Signed-off-by: Ganesh Maharaj Mahalingam <[email protected]>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-runtime that referenced this pull request Apr 16, 2019
…c-default

network: Make tcfilter model as default
(cherry picked from commit edc77a0)

Fixes: kata-containers#1501

Signed-off-by: Ganesh Maharaj Mahalingam <[email protected]>
@egernst egernst mentioned this pull request Apr 16, 2019
@amshinde amshinde deleted the make-tc-default branch July 11, 2019 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default networking model to tcfilter
7 participants