This repository has been archived by the owner on May 12, 2021. It is now read-only.
oci: Fix running of OCI hooks #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## stable-1.11 #817 +/- ##
===============================================
- Coverage 60.61% 60.61% -0.01%
===============================================
Files 17 17
Lines 2613 2618 +5
===============================================
+ Hits 1584 1587 +3
- Misses 875 877 +2
Partials 154 154 |
|
Thanks @bpradipt. But that "Fixes" issue doesn't look right? |
OCI hooks fails to run since the code was writing the config.json to the read-only path. This patch fixes it Fixes: kata-containers#818 Signed-off-by: Pradipta Kr. Banerjee <[email protected]>
bpradipt
force-pushed
the
backport-1.11
branch
from
6da9a62
to
89b9678
Compare
@jodh-intel you are right. Looks like for the original PR also the issue reference was incorrect. I created a new issue in agent repo and linked this PR to the same. Thanks. |
|
/test-ubuntu |
|
/test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCI hooks fails to run since the code was writing the config.json
to the read-only path. This patch fixes it
Fixes: #818
Signed-off-by: Pradipta Kr. Banerjee [email protected]