Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIP 7 - Finality Rules Improvement #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KIP 7 - Finality Rules Improvement #10

wants to merge 1 commit into from

Conversation

someone235
Copy link
Contributor

No description provided.

@someone235 someone235 changed the title Add KIP 7 Add KIP 7 - Finality Rules Improvement Sep 20, 2023
@someone235 someone235 changed the title Add KIP 7 - Finality Rules Improvement KIP 7 - Finality Rules Improvement Sep 20, 2023
@someone235
Copy link
Contributor Author

someone235 commented Sep 21, 2023 •
edited
Loading

Maybe instead of block_added_time we should record the first time it became a chain block. Because on IBD the virtual chain is determined only at last, this will prevent stalling attacks where the syncer sends blocks very slowly so the interval between now() and block_added_time will inflate.

JohnnyLawDGB
JohnnyLawDGB reviewed Nov 17, 2023
View reviewed changes
Copy link

@JohnnyLawDGB JohnnyLawDGB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic for change is sound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnnyLawDGB JohnnyLawDGB JohnnyLawDGB left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@someone235 @JohnnyLawDGB