Clean up debug log level by moving many frequent logs to trace level #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2004 +/- ##
==========================================
- Coverage 59.73% 59.64% -0.09%
==========================================
Files 663 663
Lines 31552 31552
==========================================
- Hits 18847 18820 -27
- Misses 10025 10045 +20
- Partials 2680 2687 +7
Continue to review full report at Codecov.
|
someone235
requested changes
Apr 3, 2022
app/protocol/flowcontext/blocks.go
Outdated
|
|
||
| unorphaningResults, err := f.UnorphanBlocks(block) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| log.Debugf("OnNewBlock: block %s unorphaned %d blocks", hash, len(unorphaningResults)) | ||
| log.Tracef("OnNewBlock: block %s unorphaned %d blocks", hash, len(unorphaningResults)) |
There was a problem hiding this comment.
Consider changing to Debugf
| @@ -79,11 +79,11 @@ func (flow *sendVersionFlow) start() error { | |||
| } | |||
|
|
|||
| // Wait for verack | |||
| log.Debugf("Waiting for verack") | |||
| log.Tracef("Waiting for verack") | |||
There was a problem hiding this comment.
Consider changing to Debugf
| _, err = flow.incomingRoute.DequeueWithTimeout(common.DefaultTimeout) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| log.Debugf("Got verack") | ||
| log.Tracef("Got verack") |
There was a problem hiding this comment.
Consider changing to Debugf
| } | ||
|
|
||
| // Update reindex root data store | ||
| rt.stageReindexRoot(stagingArea, newReindexRoot) | ||
| log.Debugf("Updated the reindex root to %s", newReindexRoot) | ||
| log.Tracef("Updated the reindex root to %s", newReindexRoot) |
There was a problem hiding this comment.
Maybe change to Debugf?
infrastructure/logger/utils.go
Outdated
| } | ||
| } | ||
|
|
||
| // LogMemoryStats logs memory stats for `functionName` | ||
| func LogMemoryStats(log *Logger, functionName string) { | ||
| log.Debug(NewLogClosure(func() string { | ||
| log.Trace(NewLogClosure(func() string { |
someone235
approved these changes
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.