Add DB compaction after the deletion of a DB prefix #2003
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently LevelDB does not necessarily compact data following a large delete operation, but rather marks items as deleted, which at times might increase DB size until a compaction is triggered.
Since DB size effects performance even if disk has sufficient space, it makes sense to explicitly call
Compact
whenever we delete a whole DB prefix.Specifically, this will help nodes using
migrate
to reduce DB size following the migration.