Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra data to GetBlockTemplate request #1995

Conversation

someone235
Copy link
Collaborator

@someone235 someone235 commented Mar 31, 2022

Fixes #1989

@someone235 someone235 linked an issue Mar 31, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #1995 (e691873) into dev (21b82d7) will decrease coverage by 0.01%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##              dev    #1995      +/-   ##
==========================================
- Coverage   57.17%   57.15%   -0.02%     
==========================================
  Files         685      685              
  Lines       32979    32982       +3     
==========================================
- Hits        18855    18852       -3     
- Misses      11443    11447       +4     
- Partials     2681     2683       +2     
Impacted Files Coverage Δ
cmd/kaspaminer/mineloop.go 0.00% <0.00%> (ø)
app/appmessage/rpc_get_block_template.go 100.00% <100.00%> (ø)
app/rpc/rpchandlers/get_block_template.go 47.36% <100.00%> (ø)
...ver/grpcserver/protowire/rpc_get_block_template.go 68.75% <100.00%> (+2.08%) ⬆️
...ucture/network/rpcclient/rpc_get_block_template.go 45.45% <100.00%> (ø)
infrastructure/network/rpcclient/rpc_get_info.go 45.45% <0.00%> (-18.19%) ⬇️
app/protocol/flows/v5/blockrelay/block_locator.go 52.94% <0.00%> (-11.77%) ⬇️
infrastructure/network/netadapter/router/route.go 82.85% <0.00%> (-5.72%) ⬇️
infrastructure/network/rpcclient/rpcclient.go 62.92% <0.00%> (-4.50%) ⬇️
.../protocol/flows/v5/blockrelay/handle_relay_invs.go 53.67% <0.00%> (+0.86%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b82d7...e691873. Read the comment docs.

@michaelsutton michaelsutton merged commit cb65dae into kaspanet:dev Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extraData field to GetBlockTemplate
2 participants