Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure there are no negative numbers in the progress report #1977

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

michaelsutton
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1977 (dad5794) into dev (1e56a22) will decrease coverage by 0.07%.
The diff coverage is 13.55%.

❗ Current head dad5794 differs from pull request most recent head f74a7ac. Consider uploading reports for the commit f74a7ac to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1977      +/-   ##
==========================================
- Coverage   57.98%   57.90%   -0.08%     
==========================================
  Files         676      676              
  Lines       32063    32108      +45     
==========================================
+ Hits        18591    18593       +2     
- Misses      10845    10879      +34     
- Partials     2627     2636       +9     
Impacted Files Coverage Δ
.../protocol/flows/v4/blockrelay/handle_relay_invs.go 0.00% <0.00%> (ø)
...tocol/flows/v4/blockrelay/ibd_progress_reporter.go 0.00% <0.00%> (ø)
...ocol/flows/v4/blockrelay/ibd_with_headers_proof.go 0.00% <0.00%> (ø)
.../handle_pruning_point_and_its_anticone_requests.go 63.52% <0.00%> (ø)
.../protocol/flows/v5/blockrelay/handle_relay_invs.go 53.12% <0.00%> (-0.73%) ⬇️
...ocol/flows/v5/blockrelay/ibd_with_headers_proof.go 44.39% <0.00%> (-0.19%) ⬇️
app/protocol/flows/v5/blockrelay/ibd.go 46.59% <15.38%> (-1.83%) ⬇️
...ocol/flows/v5/blockrelay/handle_request_headers.go 65.38% <16.66%> (-6.36%) ⬇️
...tocol/flows/v5/blockrelay/ibd_progress_reporter.go 77.27% <37.50%> (-22.73%) ⬇️
infrastructure/network/addressmanager/store.go 77.84% <0.00%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e44dd8...f74a7ac. Read the comment docs.

@svarogg svarogg merged commit 25410b8 into kaspanet:dev Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants