Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore not found errors from tp.transactionsOrderedByFeeRate.Remove. #1974

Merged
merged 3 commits into from
Mar 13, 2022

Conversation

svarogg
Copy link
Collaborator

@svarogg svarogg commented Mar 13, 2022

This PR doesn't fix anything. Only patches the crash that happens in expireOldTransactions when there exists a transaction that is in tp.allTransaction but not in tp.transactionsOrderedByFeeRate

@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #1974 (d81a7b3) into dev (7a95f0c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1974      +/-   ##
==========================================
- Coverage   57.99%   57.97%   -0.02%     
==========================================
  Files         676      676              
  Lines       32058    32063       +5     
==========================================
- Hits        18591    18588       -3     
- Misses      10840    10847       +7     
- Partials     2627     2628       +1     
Impacted Files Coverage Δ
.../mempool/model/ordered_transactions_by_fee_rate.go 69.23% <0.00%> (-1.83%) ⬇️
domain/miningmanager/mempool/transactions_pool.go 73.77% <0.00%> (-2.51%) ⬇️
...ructure/network/rpcclient/grpcclient/grpcclient.go 76.56% <0.00%> (-4.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a95f0c...d81a7b3. Read the comment docs.

@stasatdaglabs stasatdaglabs merged commit 1e56a22 into kaspanet:dev Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants