Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monitoring of heap and save heap profile if size is over some limit #1932

Merged
merged 5 commits into from
Jan 27, 2022

Conversation

michaelsutton
Copy link
Collaborator

Left some questions in the code which we need to address before merging this

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #1932 (a41fe27) into dev (4855d84) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1932      +/-   ##
==========================================
- Coverage   61.29%   61.19%   -0.10%     
==========================================
  Files         649      649              
  Lines       31012    31041      +29     
==========================================
- Hits        19009    18996      -13     
- Misses       9233     9270      +37     
- Partials     2770     2775       +5     
Impacted Files Coverage Δ
app/app.go 0.00% <0.00%> (ø)
util/profiling/profiling.go 0.00% <0.00%> (ø)
infrastructure/network/rpcclient/rpc_get_info.go 45.45% <0.00%> (-18.19%) ⬇️
app/protocol/flows/v4/blockrelay/block_locator.go 52.94% <0.00%> (-11.77%) ⬇️
infrastructure/network/rpcclient/rpcclient.go 60.67% <0.00%> (-6.75%) ⬇️
infrastructure/network/netadapter/router/route.go 82.85% <0.00%> (-5.72%) ⬇️
...ructure/network/rpcclient/grpcclient/grpcclient.go 76.56% <0.00%> (-4.69%) ⬇️
.../protocol/flows/v4/blockrelay/handle_relay_invs.go 53.17% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4855d84...a41fe27. Read the comment docs.

@someone235 someone235 merged commit 6d27637 into kaspanet:dev Jan 27, 2022
@michaelsutton michaelsutton deleted the heap-dumps branch January 27, 2022 10:56
svarogg pushed a commit to svarogg/kaspad that referenced this pull request Feb 8, 2022
…it (kaspanet#1932)

* Add monitoring of heap and save heap profile if size is over some limit

* Exported function

* Extract dump logic to a function (for defer close)

* Change trackHeapSize ticker interval to 10 seconds

* Add timestamp to dump file name

Co-authored-by: Ori Newman <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants