Add defaultTargetBlocksPerSecond #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elichai
reviewed
Feb 1, 2021
cmd/kaspaminer/config.go
Outdated
Comment on lines
45
to
47
| cfg := &configFlags{ | ||
| RPCServer: defaultRPCServer, | ||
| RPCServer: defaultRPCServer, | ||
| TargetBlocksPerSecond: defaultTargetBlocksPerSecond, |
There was a problem hiding this comment.
Can we instead use 2 * cfg.ActiveNetParams.TargetTimePerBlock?
(should also probably convert TargetBlocksPerSecond to a pointer so we can differentiate not specified from 0, unless we want to say that 0=default and if you want to disable just pass a very big number)
elichai
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.