Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable rust compatibility #101

Merged
merged 4 commits into from
May 5, 2020
Merged

Stable rust compatibility #101

merged 4 commits into from
May 5, 2020

Conversation

dhardy
Copy link
Collaborator

@dhardy dhardy commented May 4, 2020

It turns out compatibility with stable Rust is significantly easier than last time I evaluated this.

The make_widget! macro remains nightly-only, but is now strictly a convenience macro, thus can be avoided. Most examples will continue to use it (since it is the intended way to write GUIs), but some examples will be kept compatible with stable Rust.

The clock, hello and mandlebrot examples are now compatible with stable Rust.

Specifically:

  • proc_macro diagnostics are auto-enabled on nightly compilers
  • an unsize feature flag was added to kas-theme (and forwarded in kas-wgpu)
  • the Mandlebrot example was adjusted to avoid make_widget!

@dhardy dhardy mentioned this pull request May 4, 2020
@dhardy dhardy merged commit 390a76a into master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant