-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQL Storage #260
base: master
Are you sure you want to change the base?
Add SQL Storage #260
Conversation
This reverts commit 8b59b85.
Also I need to add the remove functionality, i would add it. Please don't close this PR. |
Now added the remove! |
Hi! Thanks for this PR. It would be very useful to have a general SQL implementation as a storage option, but I think it will make our storage solutions more complicated to maintain. So, I suggest continuing with the existing storage options and introducing the new one as a separate library. I’d be happy to add related libraries to hishel's documentation. |
Why do you think it would be more complicated to maintain? You already have many options, we can replace the |
…they can't run in parallel.
Finally it passes! |
Hello,
I was wondering, why there's no General SQL Storage. So I have added it.
I have used
SQLalchemy
for the task, and for some weird reason, it doesn't work withtrio
(async backend), but I think we can still add it.Thanks ahead for the help!