Tokenizer in C #15
Closed
Tokenizer in C #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very interesting!! Will take a look tonight thank you! |
|
Looks like #12 also has tokenizer implementation 😅 |
|
@python273 do you understand where #12 gets the vocab.bin file from? presumably a similar export script? |
karpathy
reviewed
Jul 24, 2023
| t = '\n<s>\n' | ||
| elif i == eos_id: | ||
| t = '\n</s>\n' | ||
| elif len(t) == 6 and t.startswith('<0x') and t.endswith('>'): |
There was a problem hiding this comment.
??? some comments around here could be nice. i haven't dug into sp too much but this looks odd
|
@python273 I got it working. What are the leading spaces? How does SentencePiece handles this 🤔 |
|
Solved here I think. ty!! |
|
(I didn't solve the leading space issue... leaving it there for now, will look later into what sentencepeice does with this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple. It doesn't remove leading spaces. Might be good idea to test with weird unicode?