-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests in pkg/binding for condition coverage #5388
Conversation
@XiShanYongYe-Chang please help review this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5388 +/- ##
==========================================
+ Coverage 29.41% 29.83% +0.42%
==========================================
Files 632 632
Lines 43835 43936 +101
==========================================
+ Hits 12892 13109 +217
+ Misses 30003 29868 -135
- Partials 940 959 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ok, thanks @yashpandey06 By the way, would you like to review the ut tests submitted by others? It's not mandatory, you can do it as you wish, and it's an important contribution to the community. Thank you very much! (I highly encourage you to review each other. My perspective may be subjective, but you can discuss it fully and provide more valuable review comments.) |
@XiShanYongYe-Chang , sure I would like to review uts submitted by other , that would be fun and great learning as well 😁 |
@yashpandey06 You can also review my PR's : #5366. Thanks! |
@yashpandey06 Try to add more tests, it only improved the test of coverage of binding controller by 1%. You can verify it in the file directory using |
Thanks man ! For the review , but my wasn't the coverage of 100 % , making sure the repos atleast the average safety coverage of 40 to 50 %. And coming to to checking the report i already made a report based on it . |
|
Yup ! , currently I am away from my home town so doesn't have acces to my setup , but I ll be reaching there by tomorrow, so would be reviewing many prs for sure 😁. |
That's okay. If some files are large and difficult to improve overall, and only some of the functions in the file are improved at a time, you can state which methods are improved in the PR description. |
Already did so ...thanks for the information 🙂 |
Okay, thanks for the PR. /lgtm |
Signed-off-by: Yash Pandey <[email protected]>
ba8c80d
to
7bef098
Compare
@XiShanYongYe-Chang, here are the required changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds comprehensive unit tests for the following functions in the
binding
package:needReviseReplicas
divideReplicasByJobCompletions
Which issue(s) this PR fixes:
Fixes: [lfx-mentorship-2024-September-November] Enhance Karmada controller-manager and schedule testing coverage #5235
Changes Made
Added Unit Tests for
needReviseReplicas
:Added Unit Tests for
divideReplicasByJobCompletions
:Testing