-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use single source for go version #5360
Conversation
Signed-off-by: zhzhuang-zju <[email protected]>
nice catch! /lgtm feel free to unhold after a period of time |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liangyuanpeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5360 +/- ##
=======================================
Coverage 28.90% 28.91%
=======================================
Files 632 632
Lines 43862 43862
=======================================
+ Hits 12678 12681 +3
+ Misses 30269 30268 -1
+ Partials 915 913 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…5360-upstream-release-1.10 Automated cherry pick of #5360: use single source for go version
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The setup-go action is the recommended way of using Go with GitHub Actions, because it helps ensure consistent behavior across different runners and different versions of Go. At present, we still have the following workflows for which the Go version has not been specified:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
When the Go version is not specified, the Go version in the CI environment may not match the one in the
go.mod
file. For example, recent vulnerability scans for the release-1.10 version did not properly identify vulnerabilities ingobinary
. Upon investigation, it was found that the inconsistency between the Go version in the CI environment and the one specified in thego.mod
file caused this issue.image-scan-with-set-up-go
image-scan-without-set-up-go
Does this PR introduce a user-facing change?: