Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use single source for go version #5360

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The setup-go action is the recommended way of using Go with GitHub Actions, because it helps ensure consistent behavior across different runners and different versions of Go. At present, we still have the following workflows for which the Go version has not been specified:

  • .github/workflows/ci-image-scanning.yaml
  • .github/workflows/dockerhub-latest-chart.yml
  • .github/workflows/dockerhub-released-chart.yml
  • .github/workflows/lint-chart.yaml

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
When the Go version is not specified, the Go version in the CI environment may not match the one in the go.mod file. For example, recent vulnerability scans for the release-1.10 version did not properly identify vulnerabilities in gobinary. Upon investigation, it was found that the inconsistency between the Go version in the CI environment and the one specified in the go.mod file caused this issue.
image-scan-with-set-up-go
image-scan-without-set-up-go

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 13, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 13, 2024
@liangyuanpeng
Copy link
Contributor

For example, recent vulnerability scans for the release-1.10 version did not properly identify vulnerabilities in gobinary

nice catch!

/lgtm
/approve
/hold In case anyone else wants to take a look.

feel free to unhold after a period of time

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2024
@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangyuanpeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.91%. Comparing base (223e54e) to head (64c44b0).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5360   +/-   ##
=======================================
  Coverage   28.90%   28.91%           
=======================================
  Files         632      632           
  Lines       43862    43862           
=======================================
+ Hits        12678    12681    +3     
+ Misses      30269    30268    -1     
+ Partials      915      913    -2     
Flag Coverage Δ
unittests 28.91% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@liangyuanpeng
Copy link
Contributor

/unhold

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2024
@karmada-bot karmada-bot merged commit 235ec91 into karmada-io:master Aug 13, 2024
12 checks passed
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

karmada-bot added a commit that referenced this pull request Aug 14, 2024
…5360-upstream-release-1.10

Automated cherry pick of #5360: use single source for go version
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants