Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add QPS related parameters to control the request rate of metrics-adapter to member clusters. #4809

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

chaunceyjiang
Copy link
Member

@chaunceyjiang chaunceyjiang commented Apr 8, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:

Add QPS related parameters to control the request rate of metrics-adapter to member clusters.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-metrics-adapter: Add QPS related parameters to control the request rate of metrics-adapter to member clusters.

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 8, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 8, 2024
@chaunceyjiang chaunceyjiang force-pushed the resourceVersion branch 2 times, most recently from c6c1033 to 13cec72 Compare April 10, 2024 07:34
@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 10, 2024
@chaunceyjiang
Copy link
Member Author

/cc @chaosi-zju PTAL.

@chaosi-zju
Copy link
Member

we can update the release note

@chaosi-zju
Copy link
Member

As a client, adapter has a Burst/QPS limit by default, and when the request volume is too large, it will wait for a long time.

However, when the adapter receives too many upstream (karmada-apiserver) requests and its own downstream (member cluster apiserver) requests are restricted, it will cause a backlog of requests, which in turn causes adapter memory to continue to rise.

Therefore, by setting a reasonable Burst/QPS parameter, memory rise problem can be avoided.

/LGTM

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@chaunceyjiang chaunceyjiang changed the title metrics-adapter: preserve the resourceVersion of pods/nodes feat: Add QPS related parameters to control the request rate of metrics-adapter to member clusters. Apr 10, 2024
@chaunceyjiang
Copy link
Member Author

/kind feature

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 10, 2024
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@chaunceyjiang
Copy link
Member Author

/kind-remove bug

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

…pter to member clusters.

Signed-off-by: chaunceyjiang <[email protected]>
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@karmada-bot karmada-bot merged commit fdad87e into karmada-io:master Apr 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants