-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
local up install karmada by helm #4045
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4045 +/- ##
=======================================
Coverage 31.14% 31.15%
=======================================
Files 640 640
Lines 44414 44414
=======================================
+ Hits 13833 13835 +2
+ Misses 29581 29579 -2
Partials 1000 1000
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@RainbowMango comments all resolved~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other lgtm
1d89aa8
to
3b49677
Compare
bf4bc1b
to
a23bb65
Compare
231ab96
to
31960b9
Compare
@jwcesign have a look again~ |
5842759
to
97eb5d2
Compare
CC @RainbowMango ready to merge by this PR, we can install current code by helm method in CI |
d54b9a1
to
d49c03a
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: chaosi-zju <[email protected]>
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4305
Special notes for your reviewer:
hack/local-up-karmada-helm.sh
as:then, provided your given cluster name and kubeconfig just like:
Execute the script:
You will see:
Does this PR introduce a user-facing change?: