Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local up install karmada by helm #4045

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Sep 7, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • A script using just one command to build multi-clusters by karmada helm chart
  • A CI test to install karmada by helm chart

This script can also execute on macOS

Which issue(s) this PR fixes:

Fixes #4305

Special notes for your reviewer:

  • if you already has clusters in real environment, please modify hack/local-up-karmada-helm.sh as:
# NEED_CREATE_KIND_CLUSTER customize whether you need to create clusters by kind, if you have clusters already, please unset this option
NEED_CREATE_KIND_CLUSTER=false

# LOAD_IMAGE_IN_ADVANCE if you fetch images in advance and you are using KinD clusters, may be you'd like to load it to KinD in advance too
LOAD_IMAGE_IN_ADVANCE=false

# IMAGE_FROM customize whether you need fetch images in advance, if you don't need, left empty
IMAGE_FROM=""

then, provided your given cluster name and kubeconfig just like:

KARMADA_HOST_NAME="karmada-host"
KARMADA_HOST_KUBECONFIG="${HOME}/.kube/karmada.config"

declare -A PUSH_MODE_MEMBERS
PUSH_MODE_MEMBERS["member1"]="${HOME}/.kube/member1.config"
PUSH_MODE_MEMBERS["member3"]="${HOME}/.kube/member3.config"

declare -A PULL_MODE_MEMBERS
PULL_MODE_MEMBERS["member2"]="${HOME}/.kube/member2.config"
  • if you need we to help you create several kind clusters, keep unchanged

Execute the script:

hack/local-up-karmada-helm.sh

You will see:

image

Does this PR introduce a user-facing change?:

none

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 7, 2023
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 7, 2023
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.15%. Comparing base (295dee8) to head (d94f6d3).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4045   +/-   ##
=======================================
  Coverage   31.14%   31.15%           
=======================================
  Files         640      640           
  Lines       44414    44414           
=======================================
+ Hits        13833    13835    +2     
+ Misses      29581    29579    -2     
  Partials     1000     1000           
Flag Coverage Δ
unittests 31.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hack/local-up-karmada-helm.sh Outdated Show resolved Hide resolved
hack/local-up-karmada-helm.sh Outdated Show resolved Hide resolved
hack/local-up-karmada-helm.sh Outdated Show resolved Hide resolved
hack/local-up-karmada-helm.sh Outdated Show resolved Hide resolved
@chaosi-zju
Copy link
Member Author

@RainbowMango comments all resolved~

Copy link
Member

@jwcesign jwcesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other lgtm

.github/workflows/installation.yaml Outdated Show resolved Hide resolved
hack/local-up-karmada-helm.sh Outdated Show resolved Hide resolved
@chaosi-zju
Copy link
Member Author

@jwcesign have a look again~

hack/local-up-karmada-helm.sh Outdated Show resolved Hide resolved
hack/local-up-karmada-helm.sh Outdated Show resolved Hide resolved
@chaosi-zju
Copy link
Member Author

chaosi-zju commented Dec 11, 2023

CC @RainbowMango ready to merge

by this PR, we can install current code by helm method in CI

@RainbowMango RainbowMango removed this from the v1.9 milestone Feb 29, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign liangyuanpeng, poor12 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hack/local-up-karmada-helm.sh Outdated Show resolved Hide resolved
.github/workflows/lint-chart.yaml Outdated Show resolved Hide resolved
hack/local-up-karmada-helm.sh Outdated Show resolved Hide resolved
@liangyuanpeng
Copy link
Contributor

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One command to build multi-clusters by karmada helm chart
6 participants