Add karmadactl addons subcommand by wuyingjun-lucky · Pull Request #2134 · karmada-io/karmada

wuyingjun-lucky · 2022-07-05T10:40:26Z

Co-authored-by: duanmeng duanmeng_yewu@cmss.chinamobile.com
Signed-off-by: wuyingjun wuyingjun_yewu@cmss.chinamobile.com

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add karmadactl addons subcommand
Which issue(s) this PR fixes:
Fixes #1957

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

wuyingjun-lucky · 2022-07-06T05:46:28Z

-------------------------------------------------latest test result-------------------------------------------------

wuyingjun-lucky · 2022-07-06T06:52:51Z

/assign @lonelyCZ
/assign @prodanlabs

lonelyCZ · 2022-07-08T01:44:34Z

Thanks for your hard work. I will review it ASAP.

pkg/karmadactl/addons/addons.go

lonelyCZ

Thanks for your contributions! @wuyingjun-lucky @duanmengkk

I just tested it that was very cool. I think we can start to review it, this is fisrt round.

pkg/karmadactl/addons/addons.go

pkg/karmadactl/addons/init/addon.go

pkg/karmadactl/addons/list.go

pkg/karmadactl/addons/init/list_option.go

pkg/karmadactl/addons/init/enable_option.go

pkg/karmadactl/addons/estimator/estimator.go

lonelyCZ

Thanks for your contributions! @wuyingjun-lucky @duanmengkk

I just tested it that was very cool. I think we can start to review it, this is fisrt round.

wuyingjun-lucky · 2022-07-28T09:38:35Z

@RainbowMango
Can you help to deal with this pull request ?

wuyingjun-lucky · 2022-07-29T01:34:10Z

PTAL @RainbowMango

RainbowMango · 2022-07-29T09:50:33Z

@wuyingjun-lucky is this the latest test result?
Can you help update the test result to the PR description?

wuyingjun-lucky · 2022-07-29T10:00:49Z

@wuyingjun-lucky is this the latest test result? Can you help update the test result to the PR description?

list and disable

wuyingjun-lucky · 2022-07-29T10:03:34Z

@RainbowMango

enable

wuyingjun-lucky · 2022-07-29T10:05:06Z

logs

wuyingjun-lucky · 2022-07-29T10:18:17Z

search aa result

wuyingjun-lucky · 2022-07-29T10:21:02Z

enable new cluster es

wuyingjun-lucky · 2022-07-30T06:26:26Z

@wuyingjun-lucky is this the latest test result? Can you help update the test result to the PR description?

updated

RainbowMango · 2022-07-30T07:08:31Z

Looks like it's a huge feature. Would you like to make a demo at the community meeting?

@prodanlabs Any comments?

RainbowMango · 2022-07-30T07:12:18Z

-bash-4.2# ./_output/bin/linux/amd64/karmadactl addons list --help 
List Karmada addons from Kubernetes

Does list mean to check whether supported addons are installed on a specific cluster?

In addition, enable/disable mean to install/install addons from a specific cluster?

wuyingjun-lucky · 2022-07-30T07:19:47Z

Looks like it's a huge feature. Would you like to make a demo at the community meeting?

@prodanlabs Any comments?

Of course if we are able to attend the meeting

wuyingjun-lucky · 2022-07-30T07:20:04Z

-bash-4.2# ./_output/bin/linux/amd64/karmadactl addons list --help 
List Karmada addons from Kubernetes
Does list mean to check whether supported addons are installed on a specific cluster?

In addition, enable/disable mean to install/install addons from a specific cluster?

Yes

RainbowMango · 2022-07-30T07:20:56Z

Great, looking forward to meeting you at the meeting.

wuyingjun-lucky · 2022-08-01T08:03:19Z

/reopen

karmada-bot · 2022-08-01T08:03:23Z

@wuyingjun-lucky: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wuyingjun-lucky · 2022-08-01T08:09:19Z

Bot Bug happend.
As #2283 merged. This pr closed as it refer to 2283 fix comments.

/cc @RainbowMango

RainbowMango

/approve

Thanks for your contribution. @wuyingjun-lucky

karmada-bot · 2022-08-02T08:02:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RainbowMango · 2022-08-02T08:03:54Z

Bot Bug happend.
As #2283 merged. This pr closed as it refer to 2283 fix comments.

:) Actually, this is GitHub behavior, not bot..., bot won't close issues when merging PRs.

* incorrect path to docs/enhancements is now fixed Signed-off-by: PulkitDadwal <150671733+PulkitDadwal@users.noreply.github.com>

karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 5, 2022

karmada-bot requested review from RainbowMango, lonelyCZ and prodanlabs July 5, 2022 10:40

karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 5, 2022

wuyingjun-lucky changed the title ~~Add karmadactl addons subcommand~~ [WIP]Add karmadactl addons subcommand Jul 5, 2022

karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2022

wuyingjun-lucky force-pushed the karmada_addon branch 6 times, most recently from fbadec6 to dfc947e Compare July 6, 2022 05:34

wuyingjun-lucky changed the title ~~[WIP]Add karmadactl addons subcommand~~ Add karmadactl addons subcommand Jul 6, 2022

karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2022

karmada-bot assigned lonelyCZ and prodanlabs Jul 6, 2022

lonelyCZ reviewed Jul 20, 2022

View reviewed changes

pkg/karmadactl/addons/addons.go Outdated Show resolved Hide resolved

lonelyCZ reviewed Jul 20, 2022

View reviewed changes

wuyingjun-lucky force-pushed the karmada_addon branch 7 times, most recently from 8cfcf2d to c429520 Compare July 24, 2022 14:14

lonelyCZ mentioned this pull request Jul 29, 2022

karmadactl: Introduce options subcmd to list global command-line options #2283

Merged

lonelyCZ mentioned this pull request Aug 1, 2022

chart: install together karmada and its component together use host installMode #2290

Closed

karmada-bot closed this in #2283 Aug 1, 2022

karmada-bot reopened this Aug 1, 2022

RainbowMango approved these changes Aug 2, 2022

View reviewed changes

karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022

karmada-bot merged commit bda9703 into karmada-io:master Aug 2, 2022

ONE7live mentioned this pull request Sep 14, 2022

Add karmadactl addons subcommand docs karmada-io/website#172

Closed

wuyingjun-lucky deleted the karmada_addon branch November 8, 2022 14:28

github-actions bot mentioned this pull request Feb 27, 2026

🌱 CNCF mission generation 2026-02-27 kubestellar/console-kb#6

Closed

Conversation

wuyingjun-lucky commented Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wuyingjun-lucky commented Jul 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wuyingjun-lucky commented Jul 6, 2022

Uh oh!

lonelyCZ commented Jul 8, 2022

Uh oh!

Uh oh!

lonelyCZ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lonelyCZ left a comment

Choose a reason for hiding this comment

Uh oh!

wuyingjun-lucky commented Jul 28, 2022

Uh oh!

wuyingjun-lucky commented Jul 29, 2022

Uh oh!

RainbowMango commented Jul 29, 2022

Uh oh!

wuyingjun-lucky commented Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wuyingjun-lucky commented Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wuyingjun-lucky commented Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wuyingjun-lucky commented Jul 29, 2022

Uh oh!

wuyingjun-lucky commented Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wuyingjun-lucky commented Jul 30, 2022

Uh oh!

RainbowMango commented Jul 30, 2022

Uh oh!

RainbowMango commented Jul 30, 2022

Uh oh!

wuyingjun-lucky commented Jul 30, 2022

Uh oh!

wuyingjun-lucky commented Jul 30, 2022

Uh oh!

RainbowMango commented Jul 30, 2022

Uh oh!

wuyingjun-lucky commented Aug 1, 2022

Uh oh!

karmada-bot commented Aug 1, 2022

Uh oh!

wuyingjun-lucky commented Aug 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RainbowMango left a comment

Choose a reason for hiding this comment

Uh oh!

karmada-bot commented Aug 2, 2022

Uh oh!

RainbowMango commented Aug 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

wuyingjun-lucky commented Jul 5, 2022 •

edited

Loading

wuyingjun-lucky commented Jul 6, 2022 •

edited

Loading

wuyingjun-lucky commented Jul 29, 2022 •

edited

Loading

wuyingjun-lucky commented Jul 29, 2022 •

edited

Loading

wuyingjun-lucky commented Jul 29, 2022 •

edited

Loading

wuyingjun-lucky commented Jul 29, 2022 •

edited

Loading

wuyingjun-lucky commented Aug 1, 2022 •

edited

Loading