Merge pull request #5343 from yashpandey06/test/clust_cond

Added unit test cluster_condition coverage : 100%
karmada-io · Aug 13, 2024 · 91e1733 · 91e1733
2 parents 47e53cc + 4d49f36
commit 91e1733
Showing 1 changed file with 54 additions and 0 deletions.
diff --git a/pkg/controllers/status/cluster_condition_cache_test.go b/pkg/controllers/status/cluster_condition_cache_test.go
@@ -176,6 +176,60 @@ func TestThresholdAdjustedReadyCondition(t *testing.T) {
 				Status: metav1.ConditionTrue,
 			},
 		},
+		{
+			name: "ready condition changes from true to false",
+			clusterData: &clusterData{
+				readyCondition:     metav1.ConditionTrue,
+				thresholdStartTime: time.Now().Add(-10 * time.Minute),
+			},
+			currentCondition: &metav1.Condition{
+				Type:   clusterv1alpha1.ClusterConditionReady,
+				Status: metav1.ConditionTrue,
+			},
+			observedCondition: &metav1.Condition{
+				Type:   clusterv1alpha1.ClusterConditionReady,
+				Status: metav1.ConditionFalse,
+			},
+			expectedCondition: &metav1.Condition{
+				Type:   clusterv1alpha1.ClusterConditionReady,
+				Status: metav1.ConditionTrue,
+			},
+		},
+		{
+			name: "ready condition changes from false to true",
+			clusterData: &clusterData{
+				readyCondition:     metav1.ConditionFalse,
+				thresholdStartTime: time.Now().Add(-10 * time.Minute),
+			},
+			currentCondition: &metav1.Condition{
+				Type:   clusterv1alpha1.ClusterConditionReady,
+				Status: metav1.ConditionFalse,
+			},
+			observedCondition: &metav1.Condition{
+				Type:   clusterv1alpha1.ClusterConditionReady,
+				Status: metav1.ConditionTrue,
+			},
+			expectedCondition: &metav1.Condition{
+				Type:   clusterv1alpha1.ClusterConditionReady,
+				Status: metav1.ConditionFalse,
+			},
+		},
+		{
+			name: "current condition is nil, should return observed condition",
+			clusterData: &clusterData{
+				readyCondition:     metav1.ConditionFalse,
+				thresholdStartTime: time.Now().Add(-clusterFailureThreshold),
+			},
+			currentCondition: nil,
+			observedCondition: &metav1.Condition{
+				Type:   clusterv1alpha1.ClusterConditionReady,
+				Status: metav1.ConditionTrue,
+			},
+			expectedCondition: &metav1.Condition{
+				Type:   clusterv1alpha1.ClusterConditionReady,
+				Status: metav1.ConditionTrue,
+			},
+		},
 	}
 
 	for _, tt := range tests {