Skip to content

Conversation

kasanatte
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR introduces the foundational configuration for Karmada-MCP-Server feature. It adds the necessary command-line flags and options in options.go to support both MCP and OpenAI integrations.

Which issue(s) this PR fixes:
Fixes #273

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 26, 2025
Copy link

Summary of Changes

Hello @kasanatte, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request lays the groundwork for integrating advanced functionalities by establishing the core configuration for Model Context Protocol (MCP) and OpenAI services. It defines the necessary options and flags to manage these integrations, allowing for flexible deployment and future development of AI-driven features and external protocol communication within the system.

Highlights

  • MCP and OpenAI Configuration: Introduced foundational configuration for both Model Context Protocol (MCP) and OpenAI integrations, enabling future AI assistant functionality and MCP server communication.
  • Command-Line Flags: Added new command-line flags to options.go for controlling MCP (e.g., enable-mcp, mcp-transport-mode, mcp-server-path, mcp-sse-endpoint) and OpenAI (e.g., openai-api-key, openai-model, openai-endpoint) settings.
  • Makefile Updates: Modified the Makefile to pass the newly introduced MCP and OpenAI configuration variables as arguments to the API server, and updated the help documentation to reflect these new options.
  • Configuration Initialization Robustness: Enhanced the GetDashboardConfig function in pkg/config/config.go to ensure that DockerRegistries, ChartRegistries, and MenuConfigs are explicitly initialized as empty slices if they are nil, preventing potential frontend errors.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 26, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces foundational configuration for MCP and OpenAI integration by adding new command-line flags and updating the Makefile. The changes are generally well-implemented. I've identified a couple of areas for improvement regarding code duplication in the Makefile and an opportunity for more concise code in pkg/config/config.go. My detailed feedback is in the review comments.

@warjiang
Copy link
Contributor

/assign

@kasanatte kasanatte force-pushed the feature/assistant-config branch from 97eba5d to 3f65191 Compare September 27, 2025 15:49
$(if $(MCP_TRANSPORT_MODE),--mcp-transport-mode="$(MCP_TRANSPORT_MODE)",--mcp-transport-mode="stdio") \
$(if $(KARMADA_MCP_SERVER_PATH),--mcp-server-path="$(KARMADA_MCP_SERVER_PATH)") \
$(if $(MCP_SSE_ENDPOINT),--mcp-sse-endpoint="$(MCP_SSE_ENDPOINT)")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Makefile Outdated
@echo " MCP_TRANSPORT_MODE - MCP transport mode: stdio or sse (default: stdio)"
@echo " KARMADA_MCP_SERVER_PATH - Path to MCP server binary (required for stdio mode)"
@echo " MCP_SSE_ENDPOINT - MCP SSE endpoint URL (required for sse mode)"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format problem~

@warjiang
Copy link
Contributor

/assign

@warjiang
Copy link
Contributor

/lgtm
/approve
thanks for your contribution~ @kasanatte

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: warjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2025
@karmada-bot karmada-bot merged commit 6787cee into karmada-io:main Sep 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Umbrella][Summer OSPP 2025] Integrate Karmada-MCP-Server into the Karmada Dashboard
3 participants