-
Notifications
You must be signed in to change notification settings - Fork 71
feat(config): add base configuration for MCP integration #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): add base configuration for MCP integration #274
Conversation
Summary of ChangesHello @kasanatte, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request lays the groundwork for integrating advanced functionalities by establishing the core configuration for Model Context Protocol (MCP) and OpenAI services. It defines the necessary options and flags to manage these integrations, allowing for flexible deployment and future development of AI-driven features and external protocol communication within the system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces foundational configuration for MCP and OpenAI integration by adding new command-line flags and updating the Makefile. The changes are generally well-implemented. I've identified a couple of areas for improvement regarding code duplication in the Makefile
and an opportunity for more concise code in pkg/config/config.go
. My detailed feedback is in the review comments.
/assign |
1fbae32
to
97eba5d
Compare
Signed-off-by: kasanatte <[email protected]>
97eba5d
to
3f65191
Compare
$(if $(MCP_TRANSPORT_MODE),--mcp-transport-mode="$(MCP_TRANSPORT_MODE)",--mcp-transport-mode="stdio") \ | ||
$(if $(KARMADA_MCP_SERVER_PATH),--mcp-server-path="$(KARMADA_MCP_SERVER_PATH)") \ | ||
$(if $(MCP_SSE_ENDPOINT),--mcp-sse-endpoint="$(MCP_SSE_ENDPOINT)") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Makefile
Outdated
@echo " MCP_TRANSPORT_MODE - MCP transport mode: stdio or sse (default: stdio)" | ||
@echo " KARMADA_MCP_SERVER_PATH - Path to MCP server binary (required for stdio mode)" | ||
@echo " MCP_SSE_ENDPOINT - MCP SSE endpoint URL (required for sse mode)" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format problem~
/assign |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: warjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR introduces the foundational configuration for Karmada-MCP-Server feature. It adds the necessary command-line flags and options in
options.go
to support both MCP and OpenAI integrations.Which issue(s) this PR fixes:
Fixes #273
Special notes for your reviewer:
Does this PR introduce a user-facing change?: