Add E2E tests for Propagation Policy/Cluster level in the dashboard

[SunsetB612]

No description provided.

[karmada-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign warjiang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @SunsetB612, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly updates the dashboard's End-to-End test infrastructure. It streamlines the existing test suite by removing outdated namespace-related tests and introduces new capabilities for testing workload-specific functionalities, exemplified by the new CronJob listing test. The integration of a Kubernetes client lays crucial groundwork for future E2E tests, particularly those targeting Propagation Policy and Cluster level features, by enabling direct API interactions.

Highlights

• E2E Test Suite Restructuring: Existing End-to-End tests for namespace creation, deletion, and network error handling have been removed from the dashboard's test suite.
• New Workload E2E Test: A previous namespace listing test has been refactored and renamed to specifically test the listing of CronJobs within the dashboard, indicating a shift towards workload-centric E2E coverage.
• Kubernetes Client Integration: The @kubernetes/client-node dependency has been added to the dashboard's package.json, suggesting that new E2E tests will directly interact with the Kubernetes API for more comprehensive testing scenarios.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes several end-to-end tests for namespaces and refactors one of them into a new test for the cronjob list page. This is a significant change that is not reflected in the pull request title, which could be updated to better describe the changes. I've provided a couple of suggestions to improve the new cronjob test by correcting misleading comments and variable names, and by adding an assertion to make the test more robust. Additionally, a new dependency @kubernetes/client-node is added, but it doesn't seem to be used within the scope of this PR, which might be a preparatory change for future work.

[gemini-code-assist]

The comments and variable names in this block are misleading. They refer to Statefulset while the test is for Cronjob. This should be corrected to avoid confusion and improve maintainability.

Suggested change

	// 点击可见的 Statefulset tab
	const statefulsetTab = page.locator('role=option[name="Cronjob"]');
	await statefulsetTab.waitFor({ state: 'visible', timeout: 30000 });
	await statefulsetTab.click();
	// 验证选中状态
	await expect(statefulsetTab).toHaveAttribute('aria-selected', 'true');
	// 验证 StatefulSet 列表表格可见
	// 点击可见的 Cronjob tab
	const cronjobTab = page.locator('role=option[name="Cronjob"]');
	await cronjobTab.waitFor({ state: 'visible', timeout: 30000 });
	await cronjobTab.click();
	// 验证选中状态
	await expect(cronjobTab).toHaveAttribute('aria-selected', 'true');
	// 验证 Cronjob 列表表格可见

[gemini-code-assist]

The test only verifies that the table is visible. To make the test more robust, you should also assert that the table contains the expected content, such as the column headers. For example, you can check for the 'Name' column header.

    await expect(table).toBeVisible({ timeout: 30000 });

    // 验证表格中包含预期的列头
    await expect(table.locator('thead')).toContainText('Name');

[SunsetB612]

/hold

[SunsetB612]

/unhold