Add E2E tests for Workloads/Daemonset in the dashboard

[SunsetB612]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @SunsetB612, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly updates the dashboard's end-to-end testing capabilities by shifting focus from Namespace management to Workload-specific resources, particularly Daemonsets. It streamlines the test suite by removing outdated Namespace tests and introducing a robust test for Daemonset listing, ensuring the dashboard accurately displays and interacts with these critical Kubernetes components. The changes also involve necessary dependency updates to support the new testing framework and Kubernetes client interactions.

Highlights

• E2E Test Suite Refactoring: Existing E2E tests for Namespace creation, deletion, and network error handling have been removed, and the Namespace listing test has been refactored and renamed to cover Daemonset listing.
• Daemonset E2E Test Added: A new E2E test has been introduced to verify the display and functionality of the Daemonset list within the dashboard's Workloads section.
• Dependency Updates: The project dependencies have been updated to include @kubernetes/client-node and related packages, along with an upgrade of @types/node.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds an E2E test for the DaemonSet list view, which is a good addition. The implementation of the new test is mostly correct, though I've pointed out a couple of minor typos that should be fixed for clarity and maintainability.

My main concern is the removal of three existing E2E test files for namespaces (namespace-create.spec.ts, namespace-delete.spec.ts, and namespace-network-error.spec.ts). This seems to reduce the overall test coverage. Could you please provide some context for this change in the pull request description? If these tests are being moved or refactored elsewhere, it would be great to know.

[warjiang]

/assign

[warjiang]

@SunsetB612 one more problem, you should squash all your commits, make commits more clearly ~

[SunsetB612]

@SunsetB612 one more problem, you should squash all your commits, make commits more clearly ~

ok, I have squashed them~

[warjiang]

/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: warjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [warjiang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[XiShanYongYe-Chang]

Hi @SunsetB612 could we conveniently update this year in the subsequent PR?

[SunsetB612]

ok, I‘ll update them all.