chore(build): run cucumber tests using NPM scripts instead of Grunt #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build karma 195 completed (commit e68b1deef0 by @devoto13) |
|
✅ Build karma 194 completed (commit e68b1deef0 by @devoto13) |
|
✅ Build karma 2593 completed (commit e68b1deef0 by @devoto13) |
johnjbarton
suggested changes
Apr 20, 2020
devoto13
force-pushed
the
cleanup-cucumber
branch
from
ccf9389 to
99bd930
Compare
|
✅ Build karma 196 completed (commit cfe7f2b7ff by @devoto13) |
|
✅ Build karma 2594 completed (commit cfe7f2b7ff by @devoto13) |
|
✅ Build karma 195 completed (commit cfe7f2b7ff by @devoto13) |
The main reason for this change is to be able to update Cucumber library as `grunt-cucumberjs` (mavdi/grunt-cucumberjs#110) does not support cucumber@4 and looks pretty abandoned. Grunt ecosystem is not very active for a while, so we can expect more issues of this sort in the future. Because of this and to keep docs consistent I've also added NPM scripts to run other test types (for now they just proxy to Grunt) and removed Grunt examples from the documentation. In the next PR I will update `cucumber` and perform some cleanup of the step definitions.
devoto13
force-pushed
the
cleanup-cucumber
branch
from
99bd930 to
c7fcc06
Compare
|
✅ Build karma 197 completed (commit 008026e0c9 by @devoto13) |
|
✅ Build karma 2595 completed (commit 008026e0c9 by @devoto13) |
|
✅ Build karma 196 completed (commit 008026e0c9 by @devoto13) |
johnjbarton
approved these changes
Apr 20, 2020
|
🎉 This PR is included in version 5.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
anthony-redFox
pushed a commit
to anthony-redFox/karma
that referenced
this pull request
May 16, 2023
…arma-runner#3476) The main reason for this change is to be able to update Cucumber library as `grunt-cucumberjs` (mavdi/grunt-cucumberjs#110) does not support cucumber@4 and looks pretty abandoned. Grunt ecosystem is not very active for a while, so we can expect more issues of this sort in the future. Because of this and to keep docs consistent I've also added NPM scripts to run other test types (for now they just proxy to Grunt) and removed Grunt examples from the documentation. In the next PR I will update `cucumber` and perform some cleanup of the step definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for this change is to be able to update Cucumber library as
grunt-cucumberjs(mavdi/grunt-cucumberjs#110) does not support cucumber@4 and looks pretty abandoned.Grunt ecosystem is not very active for a while, so we can expect more issues of this sort in the future. Because of this and to keep docs consistent I've also added NPM scripts to run other test types (for now they just proxy to Grunt) and removed Grunt examples from the documentation.
In the next PR I will update
cucumberand perform some cleanup of the step definitions.