-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added commit message validation to Travis CI #1989
Added commit message validation to Travis CI #1989
Conversation
becce83
to
d9c8e39
Compare
Ah, nvm. It looks like |
Thanks, the idea is good though. Ideally we would have another check different from travis showing up similar to how we have the CLA check showing up which validates the commit message. But I haven't figured out how to do that yet. |
Ah, that's easily done via Travis CI's build matrix: https://docs.travis-ci.com/user/customizing-the-build/#Build-Matrix I have a similar setup on some of my projects: https://github.com/twolfson/gmsmith/blob/1.1.0/.travis.yml#L1-L19 |
I will take a similar attempt at a setup. Although, I think we will want a |
bdbc478
to
9f4a036
Compare
9f4a036
to
8f2a9dd
Compare
Alright, this PR is now good to go. I went with the Here's an expected failing build (this revision wasn't using https://travis-ci.org/karma-runner/karma/builds/115744881 Here's a passing build: |
This is great thanks @twolfson, just going to let travis run its course before merging :) |
…e.to.travis Added commit message validation to Travis CI
Thanks again for this! |
When working on a repo, I like to commit frequently in a working branch. The
ghooks
were getting on my nerves so I removed them.However, I have realized that I was able to open #1984 with a bad commit message format as a result. To remedy that, I'm adding the commit message validation to Travis CI.
In this PR:
validate-commit-msg
tonpm run travis
to enable non-local message validation