Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] breaks build ⚠️ #1781

Merged
merged 1 commit into from
Jan 5, 2016

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello 👋

⚠️⚠️⚠️

socket.io just published its new version 1.4.0, which is covered by your current version range. After updating it in your project the build kept failing.

This means it’s possible that your software is malfunctioning, because of this update. Use this branch to work on adaptions and fixes.

Happy fixing and merging 🌴


The new version differs by 97 commits .

  • ddb3445 Release 1.4.0
  • 6eb9807 package: bumpengine.iofor sec advisory
  • 7b0073c Merge pull request #2335 from nkzawa/patch-7
  • 0313ad0 improve the chat demo
  • d310d42 package: bumpengine.io``
  • 709ceba package: bumpsocket.io-adapterfor release
  • b29312b package: bumpengine.iofor node 0.8 fix
  • 5190116 package: temporarily revert version for tests
  • ab1b36e package: bumpengine.ioforwsmemory fix
  • f7a2f35 package: bumpengine.io``
  • c348737 socket.io: increase large binary data test timeout
  • dde3737 package: bumpengine.iofor release
  • 8df4c79 Merge pull request #2325 from darrachequesne/patch-2
  • 1dfacc6 Trigger callback even when joining an already joined room
  • 35a0fe0 package: bump parser

There are 97 commits in total. See the full diff.


This pull request was created by greenkeeper.io.
It keeps your software, up to date, all the time.

Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster ⚡

@dignifiedquire dignifiedquire merged commit 8263195 into master Jan 5, 2016
@dignifiedquire
Copy link
Member

@zloirock looks like the whole socket.io/engine.io/ws upgrade is done so we can get our proper error messages back :)

@zloirock
Copy link

zloirock commented Jan 6, 2016

@dignifiedquire I think, too many legacy dependencies - makes sense do it only when this bug will be fixed in V8.

@dignifiedquire dignifiedquire deleted the greenkeeper-socket.io-1.4.0 branch January 6, 2016 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants