Updated timers for limited execution environment #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
| timer: ['value', {setTimeout: setTimeout, clearTimeout: clearTimeout}] | ||
| timer: ['value', { | ||
| setTimeout: function () { return setTimeout.apply(root, arguments)}, | ||
| clearTimeout: function (timeoutId) { clearTimeout(timeoutId)} |
There was a problem hiding this comment.
Shouldn't this be applied as well?
There was a problem hiding this comment.
setTimeout has variables args, whereas clearTimeout only ever receives a single arg. I can change it if you think this is less consistent.
|
Thanks, can you please squash your commits and change the commit message to follow our convention. |
In limited execution environments the setTimeout/clearTimeout functions need to be delegated to, rather than stored as references, otherwise an Illegal Invocation error is thrown by the runtime. Closes #1519
|
Thanks |
dignifiedquire
added a commit
that referenced
this pull request
Jul 31, 2015
Updated timers for limited execution environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In limited execution environments the setTimeout/clearTimeout functions
need to be delegated to, rather than stored as references.
This is a follow up to #1519