Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means dropping support for node 0.8.
This is pretty much working but the tests are broken as the outdated mocks library is not handling the
req.resume
andreq.pause
methods properly.Found a good replacement https://github.com/WhoopInc/supertest-as-promised and refactored all the failing tests. We should plan to move all the other tests for middleware to it as well, as it is much more reliable.
Ref #1410