Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #1170

Closed
wants to merge 1 commit into from
Closed

Conversation

bazilio91
Copy link
Contributor

No description provided.

@maksimr
Copy link
Contributor

maksimr commented Sep 8, 2014

@bazilio91 Thanks!

What is the primary purpose of updating these modules?

@bazilio91
Copy link
Contributor Author

Opera Next correct detection (useragent)

And I spent some time for other modules to upgrade "just for fun".

@maksimr
Copy link
Contributor

maksimr commented Sep 8, 2014

@bazilio91 Thanks for explanation.

For me will be good if you update only module which resolve problem with Opera and change commit message on something like: fix: Correctly detect Opera Next.
Because upgrading major version of some deps can lead to unnecessary problem in application which use karma and old version of deps.

@maksimr
Copy link
Contributor

maksimr commented Oct 4, 2014

@bazilio91 what about edits?

@bazilio91
Copy link
Contributor Author

I agree. I'll take some time about all my PRs on monday.

@bazilio91 bazilio91 closed this Nov 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants