Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build never exits #5

Closed
johanneswuerbach opened this issue Jul 5, 2013 · 8 comments
Closed

Build never exits #5

johanneswuerbach opened this issue Jul 5, 2013 · 8 comments

Comments

@johanneswuerbach
Copy link
Contributor

With startConnect: true and singleRun: true the node process is never existing on Mac and Linux (Travis).

This is the last displayed output with verbose.

INFO [launcher.sauce]: Shutting down Sauce Connect
2013-07-05 12:38:27,710 - received SIGTERM
2013-07-05 12:38:27,720 - Shutting down tunnel remote VM (please wait)
2013-07-05 12:38:28,326 - Tunnel remote VM is halting ..
2013-07-05 12:38:34,936 - Finished shutting down tunnel remote VM
2013-07-05 12:38:34,937 - \ Finished /
@vojtajina
Copy link
Contributor

Weird, it works fine for me (tried on Linux and Mac).

Can you check out sauce_connect.log (should be in your working directory)

@vojtajina
Copy link
Contributor

Also, did the tests run fine ?

@cprokopiak
Copy link

This same issue has happened to me. I can check my sauce_connect.log file when I go back to work on Monday. I tried this on Windows, for what it's worth. And for me, the tests ran without a problem. I just can never exit the process unless I close the command line window. Using ctrl+c does not exit.

@johanneswuerbach
Copy link
Contributor Author

I tested with passing and failing tests, the node process keeps running in both cases, here is the log : https://gist.github.com/johanneswuerbach/5994269

If you press ctrl+c (multiple times) INFO [launcher.sauce]: Shutting down Sauce Connect is printed, but nothing happens.

johanneswuerbach added a commit to johanneswuerbach/karma-sauce-launcher that referenced this issue Jul 14, 2013
@vojtajina
Copy link
Contributor

Hmm, the log looks correct...

On Sun, Jul 14, 2013 at 6:31 AM, Johannes Würbach
[email protected]:

I tested with passing and failing tests, the node process keeps running in
both cases, here is the log :
https://gist.github.com/johanneswuerbach/5994269

If you press ctrl+c (multiple times) INFO [launcher.sauce]: Shutting down
Sauce Connect is printed, but nothing happens.


Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-20936455
.

@vojtajina
Copy link
Contributor

Ok, I know what is the problem.
The sauce-connect-launcher has changed how it works. (It was wrong how it behaved, but I made this plugin to work with it, it looks like they fixed that, even though it's a breaking change and should not be in a patch release).

sauce-connect-launcher 0.1.9 however does not have onKill callback anymore, we need to fix that first. I will send them a pull request.

@santiycr please let me know once you have the C++ version of connect (with Node wrapper), this Java is pretty painful. Also, I can't unzip the current Sauce-Connect-latest.zip from saucelabs.com...

@johanneswuerbach
Copy link
Contributor Author

Awesome, thanks :-)

@agray
Copy link

agray commented Jan 18, 2015

This still appears to be a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants