Skip to content

test(desktop): fix stale windows-child-process needles (not a wiring regression) #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karlligamesvc-spec merged 1 commit into from
Jul 13, 2026
Merged

test(desktop): fix stale windows-child-process needles (not a wiring regression) #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions apps/desktop/electron/windows-child-process.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,24 @@ function readElectronFile(name) {
return fs.readFileSync(path.join(ELECTRON_DIR, name), 'utf8').replace(/\r\n/g, '\n')
}

// Prettier is free to re-wrap a long call's argument list across lines any
// time a nearby edit nudges it over the print width (this is exactly what
// happened in d62979a6f, which reformatted 5 of these call sites from
// single-line to multi-line in an otherwise unrelated feature commit and
// broke every needle below that assumed single-line layout). Matching on
// whitespace-collapsed text makes the assertion track the call site's
// *shape* (identifier order, adjacency) instead of its incidental line
// breaks, so a future reformat can't silently defeat this guard again.
function collapseWhitespace(str) {
return str.replace(/\s+/g, '')
}

function requireHiddenChildOptions(source, needle) {
const index = source.indexOf(needle)
const collapsedSource = collapseWhitespace(source)
const collapsedNeedle = collapseWhitespace(needle)
const index = collapsedSource.indexOf(collapsedNeedle)
assert.notEqual(index, -1, `missing call site: ${needle}`)
const snippet = source.slice(index, index + 700)
const snippet = collapsedSource.slice(index, index + 700)
assert.match(
snippet,
/hiddenWindowsChildOptions\(/,
Expand All @@ -27,7 +41,7 @@ test('desktop background child processes opt into hidden Windows consoles', () =

assert.match(source, /function hiddenWindowsChildOptions\(options = \{\}\)/)

requireHiddenChildOptions(source, "execFileSync(\n 'reg'")
requireHiddenChildOptions(source, "execFileSync('reg'")
requireHiddenChildOptions(source, 'execFileSync(pyExe')
requireHiddenChildOptions(source, 'spawn(resolveGitBinary()')
requireHiddenChildOptions(source, "execFileSync('taskkill'")
Expand Down
Loading