Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

takeout: ignore placevisit events #374

Merged
merged 2 commits into from
Feb 7, 2023
Merged

takeout: ignore placevisit events #374

merged 2 commits into from
Feb 7, 2023

Conversation

purarue
Copy link
Contributor

@purarue purarue commented Feb 4, 2023

this might ImportError for people if they have not upgraded google_takeout_parser... should a warning be added there?

@purarue
sources/takeout: use type name for seen set
08be0ff 
this prevents import errors if the user
has not recently updated the
google_takeout_parser
@purarue
Copy link
Contributor Author

purarue commented Feb 7, 2023

Somewhat related: karlicoss/HPI#266

@karlicoss karlicoss merged commit 175c5f6 into karlicoss:master Feb 7, 2023
@karlicoss
Copy link
Owner

thanks, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlicoss karlicoss Awaiting requested review from karlicoss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@purarue @karlicoss