Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smscalls: make checking for keys stricter #289

Merged
merged 1 commit into from
Apr 15, 2023

Commits on Apr 15, 2023

  1. smscalls: make checking for keys stricter

    sort of reverts karlicoss#287, but also makes some other improvements
    
    this allows us to remove some of the Optional's to
    make downstream consumers easier to write. However,
    this keeps the return type as a Res (result, with errors),
    so downstream consumers will have to handle those incase
    the schema ever changes (highly unlikely)
    
    also added the 'call_type/message_type' with a comment
    there describing the values
    
    I left 'who' Optional I believe it actually should be -
    its very possible for there to be no contact name, added
    a check incase its '(Unknown)' which is what my phone
    sets it to
    purarue committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    4afa899 View commit details
    Browse the repository at this point in the history