Skip to content

fix: only trigger reorg on actual conflicts, not generic errors #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
opsuperchain wants to merge 1 commit into from
Closed

fix: only trigger reorg on actual conflicts, not generic errors #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions op-interop-filter/filter/chain_ingester.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,14 +354,10 @@ func (c *ChainIngester) catchUp() error {
}

// Step 4: Backfill to head
if err := c.backfill(startBlock, head.NumberU64()); err != nil {
if !errors.Is(err, context.Canceled) {
c.triggerReorg()
}
return err
}

return nil
// Note: reorg detection happens inside ingestBlock via parent hash mismatch
// and inside processBlockLogs via ErrConflict - we don't trigger reorg on
// generic errors like RPC failures
return c.backfill(startBlock, head.NumberU64())
}

// determineStartBlock figures out where to start ingestion.
Expand Down